Diffusion Ark 0eb0efbc6725

Fix libzip cmake module

Authored by elvisangelaccio on Mar 18 2017, 2:46 PM.

Description

Fix libzip cmake module

libzip installs zipconf.h in $prefix/$libdir/libzip/include/. Some
systems (e.g. archlinux) symlink this file under $prefix/$libdir/include
for compatibility reasons, but cmake fails on systems that do not (e.g.
flatpak). Since libzip supports pkg-config, we can just query pkg-config
which gives us the proper path we are looking for. While at it, use
pkg-config also to get the library version (replacing our custom parsing code
which does not work) and follow general cmake best-practices.

This breaks the Applications dependency freeze, but it's an important
fix so it should go in.

Differential Revision: D5101

Details

Committed
elvisangelaccioMar 18 2017, 8:41 PM
Differential Revision
D5101: Fix libzip cmake module
Parents
R36:561ba8ee8254: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown