Diffusion Ark 0d16e7d028a0

Fix crash with blocking Open dialog

Authored by elvisangelaccio on Jun 9 2016, 9:18 AM.

Description

Fix crash with blocking Open dialog

QDialog::exec() is bad and should not be used unless strictly necessary.
The exec() call is blocking and anything can happen before it returns to the caller.

The old workaround is to use a QPointer to guard the dialog.
Yet there is a crash when calling QCoreApplication::quit() via dbus while the dialog is open.

The proper fix is to call the dialog in a non-blocking way. Nowadays this is trivial thanks to C++11 lambdas.

Differential Revision: D1786

Details

Committed
elvisangelaccioJun 9 2016, 9:19 AM
Differential Revision
D1786: Fix crash with blocking Open dialog
Parents
R36:f73b4fba4c30: GIT_SILENT Upgrade KDE Applications version to 16.04.2.
Branches
Unknown
Tags
Unknown
References
tag: v16.04.2