Add openDeclaration(Identifier) overload to AbstractDeclarationBuilder

Authored by nalvarez on Apr 21 2017, 3:26 AM.

Description

Add openDeclaration(Identifier) overload to AbstractDeclarationBuilder

As discussed on the mailing list, openDeclaration(QualifiedIdentifier)
makes little sense semantically, and in practice it's just taking the last
Identifier from the QID and using that.

Make it take an Identifier instead, leaving a QualifiedIdentifier overload
calling openDeclaration(id.last()) for compatibility. Also, print a warning
if it's called with a QualifiedIdentifier that actually has more than one
Identifier in it (I haven't seen this happen).

Details

Committed
nalvarezApr 21 2017, 3:26 AM
Parents
R33:af4a4ccaf561: Merge branch '5.1'
Branches
Unknown
Tags
Unknown
kfunk added a subscriber: kfunk.Apr 27 2017, 8:15 AM
kfunk added inline comments.
/language/duchain/builders/abstractdeclarationbuilder.h
88

Should we mark this deprecated?

nalvarez marked an inline comment as done.May 5 2017, 1:44 AM
nalvarez added inline comments.
/language/duchain/builders/abstractdeclarationbuilder.h
88

Yes; done in 782baa2ecd.