Use explicit flag values or explicit constructor instead of nullptr

Authored by kossebau on May 30 2017, 10:25 PM.

Description

Use explicit flag values or explicit constructor instead of nullptr

Summary:
The constructor of QFlags which was intended to handle literal "0"
as commonly used indicator of no-flags-set has been done with a
trick based on pointer types. Which these days of nullptr existing and
compilers pushing to use that sadly fired back and, instead of
allowing convenient code with commonly understood literal "0" values,
resulted in quite some code using "nullptr" to indicate a QFLags-based
type value with no flags set, which can be puzzling for humans
reading the code

To improve the code again IMHO, instead of "nullptr" are used:

  • enum item representing the 0=no-flag-set value, if existing
  • explicit constructor (or {} for default arg values, given arg type is aƶready noted as part of arg definition)

Reviewers: KDevelop, kfunk

Reviewed By: KDevelop, kfunk

Subscribers: kdevelop-devel

Differential Revision: https://phabricator.kde.org/D6050