Default to disabled debug log on Q_LOGGING_CATEGORY calls
ddf0a6fc36d9
Actions

Authored by kossebau on Apr 30 2017, 12:49 PM.

Description

Default to disabled debug log on Q_LOGGING_CATEGORY calls

Summary:
This removes the need to call QLoggingCategory::setFilterRules()
in the program code to default to disabled debug type log
without any other settings.
The latter has disadvantages, as it shadows any settings done
in qtlogging.ini config files by the user
(e.g. via kdebugsettings), thus enabling runtime control only
via QT_LOGGING_CONF/QT_LOGGING_RULES, which is not that
comfortable with lots of categories.

Also use ECMQtDeclareLoggingCategory for less manual code

While there can be some inconsistency with the default disabled
log categories by ECMQtDeclareLoggingCategory, which
switched to QtInfoMsg for ECM 5.26 (when KF5 5.26 has Qt 5.5
as min dep, which is the Qt version QtInfoMsg was added),
current KDevPlatform code has Qt 5.4 as minimum version and
thus also does not use qCInfo, so KDevPlatform behaviour should
be the same across used Qt versions.

Reviewers: KDevelop, kfunk

Reviewed By: KDevelop, kfunk

Subscribers: apol, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D5666

Details

Committed

kossebau

May 12 2017, 2:52 PM

Reviewer

KDevelop

Differential Revision

D5666: Default to disabled debug log on Q_LOGGING_CATEGORY calls

Parents

R32:ddc761c3e683: Merge branch '5.1'

Branches

Unknown

Tags

Unknown

kossebau committed R32:ddf0a6fc36d9: Default to disabled debug log on Q_LOGGING_CATEGORY calls (authored by kossebau).May 12 2017, 2:52 PM

Changes (222)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path	Packages
	M			CMakeLists.txt
	M			debugger/CMakeLists.txt
	M			debugger/breakpoint/breakpointmodel.cpp
	M			debugger/breakpoint/breakpointwidget.cpp
	M			debugger/framestack/framestackmodel.cpp
	M			debugger/framestack/framestackwidget.cpp
	M			debugger/interfaces/ibreakpointcontroller.cpp
	M			debugger/interfaces/idebugsession.cpp
	M			debugger/interfaces/ivariablecontroller.cpp
	D			debugger/util/debug.cpp
	D			debugger/util/debug.h
	M			debugger/util/pathmappings.cpp
	M			debugger/util/treeitem.cpp
	M			debugger/variable/variablecollection.cpp
	M			debugger/variable/variablewidget.cpp
	M			documentation/CMakeLists.txt
	D			documentation/debug.h
	M			documentation/documentationview.cpp
	M			language/CMakeLists.txt
	M			language/assistant/renameassistant.cpp
	M			language/assistant/renamefileaction.cpp
	M			language/assistant/staticassistantsmanager.cpp
	M			language/backgroundparser/backgroundparser.cpp
	M			language/backgroundparser/documentchangetracker.cpp
	M			language/backgroundparser/parsejob.cpp
	M			language/backgroundparser/parseprojectjob.cpp
	M			language/classmodel/classmodelnode.cpp
	M			language/codecompletion/abstractincludefilecompletionitem.h
	M			language/codecompletion/codecompletion.cpp
	M			language/codecompletion/codecompletioncontext.cpp
	M			language/codecompletion/codecompletionitem.cpp
	M			language/codecompletion/codecompletionmodel.cpp
	M			language/codecompletion/codecompletionworker.cpp
	M			language/codecompletion/normaldeclarationcompletionitem.cpp
	M			language/codegen/basicrefactoring.cpp
	M			language/codegen/codedescription.cpp
	M			language/codegen/codegenerator.cpp
	M			language/codegen/codegenerator.h
	M			language/codegen/documentchangeset.cpp
	M			language/codegen/duchainchangeset.cpp
	M			language/codegen/sourcefiletemplate.cpp
	M			language/codegen/templateclassgenerator.cpp
	M			language/codegen/templatepreviewicon.cpp
	M			language/codegen/templaterenderer.cpp
	M			language/codegen/templatesmodel.cpp
	M			language/codegen/utilities.cpp
	M			language/duchain/classdeclaration.cpp
	M			language/duchain/classfunctiondeclaration.cpp
	M			language/duchain/codemodel.cpp
	M			language/duchain/duchain.cpp
	M			language/duchain/duchainutils.cpp
	M			language/duchain/ducontext.cpp
	M			language/duchain/functiondeclaration.cpp
	M			language/duchain/identifier.cpp
	M			language/duchain/navigation/abstractdeclarationnavigationcontext.cpp
	M			language/duchain/navigation/abstractnavigationcontext.cpp
	M			language/duchain/navigation/abstractnavigationwidget.cpp
	M			language/duchain/navigation/problemnavigationcontext.cpp
	M			language/duchain/navigation/usescollector.cpp
	M			language/duchain/navigation/useswidget.cpp
	M			language/duchain/parsingenvironment.cpp
	M			language/duchain/stringhelpers.cpp
	M			language/duchain/topducontext.cpp
	M			language/duchain/topducontextdynamicdata.cpp
	M			language/duchain/types/abstracttype.cpp
	M			language/duchain/types/constantintegraltype.cpp
	M			language/duchain/types/identifiedtype.cpp
	M			language/duchain/types/typerepository.cpp
	M			language/editor/modificationrevisionset.cpp
	M			language/highlighting/codehighlighting.cpp
	M			language/highlighting/colorcache.cpp
	M			language/highlighting/configurablecolors.cpp
	D			language/util/debug.cpp
	D			language/util/debug.h
	M			language/util/setrepository.cpp
	M			outputview/CMakeLists.txt
	D			outputview/debug.h
	M			outputview/ioutputview.cpp
	M			plugins/appwizard/CMakeLists.txt
	M			plugins/appwizard/appwizardplugin.cpp
	D			plugins/appwizard/debug.h
	M			plugins/classbrowser/CMakeLists.txt
	M			plugins/classbrowser/classbrowserplugin.cpp
	D			plugins/classbrowser/debug.h
	M			plugins/codeutils/CMakeLists.txt
	M			plugins/codeutils/codeutilsplugin.cpp
	M			plugins/codeutils/codeutilsplugin.h
	M			plugins/contextbrowser/CMakeLists.txt
	M			plugins/contextbrowser/contextbrowser.cpp
	D			plugins/contextbrowser/debug.h
	M			plugins/cvs/CMakeLists.txt
	M			plugins/cvs/cvsplugin.cpp
	M			plugins/cvs/cvsproxy.cpp
	D			plugins/cvs/debug.h
	M			plugins/cvs/tests/CMakeLists.txt
	M			plugins/cvs/tests/test_cvs.cpp
	M			plugins/documentswitcher/CMakeLists.txt
	M			plugins/documentswitcher/documentswitcherplugin.cpp
	M			plugins/documentswitcher/documentswitcherplugin.h
	M			plugins/execute/CMakeLists.txt
	D			plugins/execute/debug.h
	M			plugins/execute/executeplugin.cpp
	M			plugins/execute/nativeappconfig.cpp
	M			plugins/execute/nativeappjob.cpp
	M			plugins/executescript/CMakeLists.txt
	D			plugins/executescript/debug.h
	M			plugins/executescript/executescriptplugin.cpp
	M			plugins/executescript/scriptappjob.cpp
	M			plugins/externalscript/CMakeLists.txt
	D			plugins/externalscript/externalscriptdebug.cpp
	D			plugins/externalscript/externalscriptdebug.h
	M			plugins/externalscript/externalscriptjob.cpp
	M			plugins/externalscript/externalscriptplugin.cpp
	M			plugins/filemanager/CMakeLists.txt
	D			plugins/filemanager/debug.h
	M			plugins/filemanager/filemanager.cpp
	M			plugins/filetemplates/CMakeLists.txt
	D			plugins/filetemplates/debug.cpp
	D			plugins/filetemplates/debug.h
	M			plugins/git/CMakeLists.txt
	D			plugins/git/debug.h
	M			plugins/git/gitplugin.cpp
	M			plugins/git/tests/CMakeLists.txt
	M			plugins/grepview/CMakeLists.txt
	D			plugins/grepview/debug.h
	M			plugins/grepview/grepviewplugin.cpp
	M			plugins/grepview/tests/CMakeLists.txt
	M			plugins/konsole/CMakeLists.txt
	D			plugins/konsole/debug.h
	M			plugins/konsole/kdevkonsoleviewplugin.cpp
	M			plugins/outlineview/CMakeLists.txt
	D			plugins/outlineview/debug_outline.h
	M			plugins/outlineview/outlinemodel.cpp
	M			plugins/outlineview/outlinenode.cpp
	M			plugins/outlineview/outlineviewplugin.cpp
	M			plugins/patchreview/CMakeLists.txt
	D			plugins/patchreview/debug.h
	M			plugins/patchreview/patchreview.cpp
	M			plugins/perforce/CMakeLists.txt
	D			plugins/perforce/debug.h
	M			plugins/perforce/perforceplugin.cpp
	M			plugins/perforce/test/CMakeLists.txt
	M			plugins/problemreporter/CMakeLists.txt
	M			plugins/problemreporter/problemreporterplugin.cpp
	M			plugins/problemreporter/problemreporterplugin.h
	M			plugins/projectfilter/CMakeLists.txt
	M			plugins/projectfilter/projectfilterconfigpage.cpp
	D			plugins/projectfilter/projectfilterdebug.cpp
	D			plugins/projectfilter/projectfilterdebug.h
	M			plugins/projectfilter/projectfilterprovider.cpp
	M			plugins/projectmanagerview/CMakeLists.txt
	D			plugins/projectmanagerview/debug.h
	M			plugins/projectmanagerview/projectmanagerviewplugin.cpp
	M			plugins/quickopen/CMakeLists.txt
	M			plugins/quickopen/actionsquickopenprovider.cpp
	D			plugins/quickopen/debug.h
	M			plugins/quickopen/expandingtree/expandingdelegate.cpp
	M			plugins/quickopen/expandingtree/expandingwidgetmodel.cpp
	M			plugins/quickopen/quickopenmodel.cpp
	M			plugins/quickopen/quickopenplugin.cpp
	M			plugins/standardoutputview/CMakeLists.txt
	D			plugins/standardoutputview/debug.h
	M			plugins/standardoutputview/outputwidget.cpp
	M			plugins/standardoutputview/tests/CMakeLists.txt
	M			plugins/subversion/CMakeLists.txt
	D			plugins/subversion/debug.h
	M			plugins/subversion/kdevsvnplugin.cpp
	M			plugins/switchtobuddy/CMakeLists.txt
	M			plugins/switchtobuddy/switchtobuddyplugin.cpp
	M			plugins/switchtobuddy/switchtobuddyplugin.h
	M			plugins/testview/CMakeLists.txt
	M			plugins/testview/testview.cpp
	D			plugins/testview/testviewdebug.cpp
	D			plugins/testview/testviewdebug.h
	M			project/debug.cpp
	M			project/projectmodel.cpp
	M			project/projectproxymodel.cpp
	M			serialization/CMakeLists.txt
	D			serialization/debug.cpp
	D			serialization/debug.h
	M			serialization/itemrepositoryregistry.cpp
	M			shell/CMakeLists.txt
	M			shell/configdialog.cpp
	D			shell/debug.cpp
	D			shell/debug.h
	M			shell/loadedpluginsdialog.cpp
	M			shell/openprojectdialog.cpp
	M			shell/partcontroller.cpp
	M			shell/plugincontroller.cpp
	M			shell/progresswidget/progressmanager.cpp
	M			shell/project.cpp
	M			shell/runcontroller.cpp
	M			shell/sessionlock.cpp
	M			shell/settings/environmentwidget.cpp
	M			shell/settings/pluginpreferences.cpp
	M			shell/settings/sourceformattersettings.cpp
	M			shell/textdocument.cpp
	M			shell/workingsets/closedworkingsetswidget.cpp
	M			shell/workingsets/workingset.cpp
	M			shell/workingsets/workingsettooltipwidget.cpp
	M			shell/workingsets/workingsetwidget.cpp
	M			sublime/CMakeLists.txt
	M			sublime/area.cpp
	M			sublime/areaindex.cpp
	M			sublime/controller.cpp
	M			sublime/mainwindow.cpp
	M			sublime/mainwindow_p.cpp
	D			sublime/sublimedebug.h
	M			util/CMakeLists.txt
	D			util/debug.cpp
	D			util/debug.h
	M			util/formattinghelpers.cpp
	M			util/placeholderitemproxymodel.cpp
	M			vcs/CMakeLists.txt
	D			vcs/debug.cpp
	D			vcs/debug.h
	M			vcs/dvcs/dvcsjob.cpp
	M			vcs/dvcs/ui/branchmanager.cpp
	M			vcs/models/brancheslistmodel.cpp
	M			vcs/widgets/vcsdiffpatchsources.cpp
	M			vcs/widgets/vcsdiffwidget.cpp
	M			vcs/widgets/vcseventwidget.cpp

Default to disabled debug log on Q_LOGGING_CATEGORY callsddf0a6fc36d9Actions

Description

Details

Changes (222)Show All Changes

Very Large Commit

R32:ddf0a6fc36d9

CMakeLists.txt

debugger/CMakeLists.txt

debugger/breakpoint/breakpointmodel.cpp

debugger/breakpoint/breakpointwidget.cpp

debugger/framestack/framestackmodel.cpp

debugger/framestack/framestackwidget.cpp

debugger/interfaces/ibreakpointcontroller.cpp

debugger/interfaces/idebugsession.cpp

debugger/interfaces/ivariablecontroller.cpp

debugger/util/debug.cpp

debugger/util/debug.h

debugger/util/pathmappings.cpp

debugger/util/treeitem.cpp

debugger/variable/variablecollection.cpp

debugger/variable/variablewidget.cpp

documentation/CMakeLists.txt

documentation/debug.h

documentation/documentationview.cpp

language/CMakeLists.txt

language/assistant/renameassistant.cpp

language/assistant/renamefileaction.cpp

language/assistant/staticassistantsmanager.cpp

language/backgroundparser/backgroundparser.cpp

language/backgroundparser/documentchangetracker.cpp

language/backgroundparser/parsejob.cpp

language/backgroundparser/parseprojectjob.cpp

language/classmodel/classmodelnode.cpp

language/codecompletion/abstractincludefilecompletionitem.h

language/codecompletion/codecompletion.cpp

language/codecompletion/codecompletioncontext.cpp

language/codecompletion/codecompletionitem.cpp

language/codecompletion/codecompletionmodel.cpp

language/codecompletion/codecompletionworker.cpp

language/codecompletion/normaldeclarationcompletionitem.cpp

language/codegen/basicrefactoring.cpp

language/codegen/codedescription.cpp

language/codegen/codegenerator.cpp

language/codegen/codegenerator.h

language/codegen/documentchangeset.cpp

language/codegen/duchainchangeset.cpp

language/codegen/sourcefiletemplate.cpp

language/codegen/templateclassgenerator.cpp

language/codegen/templatepreviewicon.cpp

language/codegen/templaterenderer.cpp

language/codegen/templatesmodel.cpp

language/codegen/utilities.cpp

language/duchain/classdeclaration.cpp

language/duchain/classfunctiondeclaration.cpp

language/duchain/codemodel.cpp

language/duchain/duchain.cpp

language/duchain/duchainutils.cpp

language/duchain/ducontext.cpp

language/duchain/functiondeclaration.cpp

language/duchain/identifier.cpp

language/duchain/navigation/abstractdeclarationnavigationcontext.cpp

language/duchain/navigation/abstractnavigationcontext.cpp

language/duchain/navigation/abstractnavigationwidget.cpp

language/duchain/navigation/problemnavigationcontext.cpp

language/duchain/navigation/usescollector.cpp

language/duchain/navigation/useswidget.cpp

language/duchain/parsingenvironment.cpp

language/duchain/stringhelpers.cpp

language/duchain/topducontext.cpp

language/duchain/topducontextdynamicdata.cpp

language/duchain/types/abstracttype.cpp

language/duchain/types/constantintegraltype.cpp

language/duchain/types/identifiedtype.cpp

language/duchain/types/typerepository.cpp

language/editor/modificationrevisionset.cpp

language/highlighting/codehighlighting.cpp

language/highlighting/colorcache.cpp

language/highlighting/configurablecolors.cpp

language/util/debug.cpp

language/util/debug.h

Default to disabled debug log on Q_LOGGING_CATEGORY calls
ddf0a6fc36d9
Actions

Changes (222)
Show All Changes