Fix crashy dialogs (found by krazy and by hand)
7cda7c95d5bf
Actions

Authored by croick on Jun 30 2017, 9:36 PM.

Description

Fix crashy dialogs (found by krazy and by hand)

Summary:

use a wrapper class which simplifies the use of QPointer for the creation of local QDialogs
some false positives are marked
some dialogs not identified by krazy have the main window as parent, they may still cause a crash, when the program is killed

Test Plan:
Before:

After:

Reviewers: KDevelop, apol

Reviewed By: KDevelop, apol

Subscribers: apol, anthonyfieroni, kdevelop-devel

Committed

croick

Jun 30 2017, 9:57 PM

Reviewer

KDevelop

Differential Revision

D6308: Fix crashy dialogs (found by krazy and by hand)

Parents

R32:c6dd6e648481: Merge branch '5.1'

Branches

Unknown

Tags

Unknown

				Path	Packages
	M			language/codegen/basicrefactoring.cpp
	M			plugins/appwizard/appwizardplugin.cpp
	M			plugins/appwizard/projectselectionpage.cpp
	M			plugins/externalscript/externalscriptview.cpp
	M			plugins/filetemplates/templateclassassistant.cpp
	M			plugins/filetemplates/templateselectionpage.cpp
	M			plugins/git/gitplugin.cpp
	M			plugins/subversion/kdevsvnplugin.cpp
	M			plugins/subversion/svnjobbase.cpp
	M			shell/documentcontroller.cpp
	M			shell/environmentconfigurebutton.cpp
	M			shell/loadedpluginsdialog.cpp
	M			shell/mainwindow_actions.cpp
	M			shell/projectcontroller.cpp
	M			shell/sessioncontroller.cpp
	M			shell/settings/environmentwidget.cpp
	M			shell/settings/sourceformattersettings.cpp
	M			shell/settings/templatepage.cpp
	M			shell/uicontroller.cpp
	A			util/scopeddialog.h
	M			vcs/dvcs/dvcsplugin.cpp
	M			vcs/vcspluginhelper.cpp