Revert "Don't set up DocumentationViews when shutting down"

Authored by kfunk on Oct 13 2017, 8:16 AM.

Description

Revert "Don't set up DocumentationViews when shutting down"

Several issues:
a) unreviewed
b) returning inside a constructor is bad habit, as it may leave the
class instance half-initialized
c) the fix is at the wrong location, the DocumentationView ctor should
not be called in the first place => find out *when* it is being called
during shutdown (=> put breakpoint on DocumentationView() in gdb, lldb)

This reverts commit 4b4806d02ad099b5ef3062286a1dfdef21195ee4.