use QUrl::fromUserInput to construct sound url

Authored by sitter on May 9 2016, 7:27 AM.

Description

use QUrl::fromUserInput to construct sound url

QUrl() would treats it as a parsable uri, but they aren't e.g. # in a uri
separates segments in a local file path it simply is a #.
This "accidentally" worked in Phonon < 4.9 as Phonon obtained string
representations in a way that would bypass internal QUrl checks for
fileyness and URI ambiguity. Since 4.9 Phonon expects scheme-less URLs to
be local files, but QUrl() would most of the time not do that since it
would honestly think the soundfilename is a random (i.e. not necessarily
local) uri.

To fix this use QUrl::fromUserInput which behaves exactly like what we
need to properly resolve relative names, urls, paths, full URIs.

This now works with input of the type:

(yes, we can have http notifications!!!! https://xkcd.com/1172/)

CCBUG: 337276
REVIEW: 127829

Details

Committed
sitterMay 9 2016, 7:27 AM
Parents
R305:4d5077091200: Upgrade ECM and KF5 version requirements for 5.22.0 release.
Branches
Unknown
Tags
Unknown