Oware: fix global score, move animation to house

Authored by dmadaan on Jun 28 2017, 7:22 AM.

Description

Oware: fix global score, move animation to house

Details

Committed
dmadaanJun 28 2017, 7:22 AM
Parents
R2:1383042cc0bc: Oware: Add initial animations for seeds
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptJun 28 2017, 7:21 AM
jjazeix added inline comments.Jun 28 2017, 8:12 AM
/src/activities/oware/oware.js
212

I don't think it's necessary to pass the index there (the second one), you already have it in the Repeater

dmadaan added inline comments.Jun 28 2017, 9:58 AM
/src/activities/oware/oware.js
212

yes, I removed it thereafter (it requires the actual index and not this index). https://gist.github.com/divyam3897/b4f73ff55b10c7cddd552e6a888f6ca7 I have commented "setValues()" in this patch though I still don't see the animation...