Diffusion GCompris 8fddfdbf1094

Fix issues when music is downloaded for the first time
8fddfdbf1094
Actions

Authored by dmadaan on May 27 2017, 2:47 PM.

Description

Fix issues when music is downloaded for the first time

Details

Committed
dmadaanMay 27 2017, 2:47 PM
Parents
R2:1e652d5de9b1: Clean code
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptMay 27 2017, 9:27 AM
jjazeix added inline comments.May 27 2017, 10:09 AM
/src/core/DownloadManager.cpp
529

If we register words.rcc (or any activity rcc if we go by this code, what I'm not sure for activities), I think it will go there have you checked?

/src/core/DownloadManager.h
382

I would call it backgroundMusicRegistered and add a documentation

dmadaan marked an inline comment as done.May 27 2017, 1:23 PM
dmadaan added inline comments.
/src/core/DownloadManager.cpp
529

yes, I checked and you are right it goes there when the words.rcc is registered but it doesn't affect the music which is played or doesn't register music again. So is its not a problem?

jjazeix added inline comments.May 27 2017, 2:04 PM
/src/core/DownloadManager.cpp
529

it does not cause an issue in this case but it would still be better to not trigger musicRegistered if it's not the music rcc. If it's not installed for example, it should not trigger the code.

Changes (3)

PathPackages
Msrc/core/DownloadManager.cpp
Msrc/core/DownloadManager.h
Msrc/core/main.qml

R2:8fddfdbf1094

View Options

src/core/DownloadManager.cpp

Loading...
View Options

src/core/DownloadManager.h

Loading...
View Options

src/core/main.qml

Loading...