Background music: Fix bad url, play music at coorect time, start stop of music…

Authored by dmadaan on Jun 26 2017, 10:05 AM.

Description

Background music: Fix bad url, play music at coorect time, start stop of music in musical activities

Details

Committed
dmadaanJun 26 2017, 10:05 AM
Parents
R2:9055d2277218: Emit music signal only when music is downloaded/registered
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. · View Herald TranscriptJun 26 2017, 10:06 AM
jjazeix added inline comments.Jun 28 2017, 11:29 AM
/src/activities/explore_farm_animals/ExploreLevels.qml
295

why in the DialogHelp and not in the activity itself?

dmadaan added inline comments.Jun 28 2017, 12:01 PM
/src/activities/explore_farm_animals/ExploreLevels.qml
295

I saw the music being involved in the dialog for explore musical instuments (you play the music in dialog). The music doesn't stop for now but that is how I am thinking for it to be. Also in many activities we have audio voices so not sure but should music be stopped in that case also? Can you also please check the way it's done in gtk+ (either stopped in all activities or just on entering the musical and stopped when we exit the activity)? It was stopped in gtk+ if I remember (I lost voice effects in gtk+ version due to some reason to test it...)