Small issues are fixed || Code Cleaned

Authored by nitish on Jan 5 2017, 8:15 PM.

Description

Small issues are fixed || Code Cleaned

Details

Committed
nitishJan 5 2017, 8:15 PM
Parents
R2:3d0cf6547558: Repeaters problem resolved
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptJan 5 2017, 8:16 PM
jjazeix added inline comments.Jan 5 2017, 8:34 PM
/src/activities/multiplication_tables/Multiplication_tables.qml
39

can you give a more comprehensive name? ALso from what I read it's used as a boolean so it would be better to have it as it.

40

you can remove the line break

/src/activities/multiplication_tables/Question.qml
29

This one can probably be a Flow instead of a Row. For example, if you have a long question, it would be better to have it full width and put the answer field below

45

qsTr() ?

/src/activities/multiplication_tables/multiplication_tables.js
74

this only works in case of mathematics activities? For me, items.repeater.itemAt(i).questionText should just be question[i]

nitish marked 3 inline comments as done.Jan 7 2017, 5:52 AM

Thanks for the feedback.
I will include the changes you mentioned.

regards.