Note names: Fixes and improvements 1. Implement reload button 2. Fix keyboard…
7051c710aaae
Actions

Authored by dmadaan on Aug 4 2017, 6:04 PM.

Description

Note names: Fixes and improvements 1. Implement reload button 2. Fix keyboard controls 3. Improve instructions margin 4. Improve highlight (place to unhighlight to be seen) 5. Fix button text

Details

Committed

dmadaan

Aug 4 2017, 6:04 PM

Parents

R2:74ee8e498f10: Play piano: Remove unused items

Branches

Unknown

Tags

Unknown

dmadaan committed R2:7051c710aaae: Note names: Fixes and improvements 1. Implement reload button 2. Fix keyboard… (authored by dmadaan).Aug 4 2017, 6:04 PM

Restricted Application added a subscriber: jjazeix. · View Herald TranscriptAug 4 2017, 6:06 PM

jjazeix added inline comments.Aug 9 2017, 10:30 AM

/src/activities/note_names/note_names.js
55	why do you put it twice? (here and after the for loop)

Changes (3)

				Path	Packages
	M			src/activities/note_names/NoteNames.qml
	M			src/activities/note_names/note_names.js
	M			src/activities/playpiano/Playpiano.qml

R2:7051c710aaae

View Options

src/activities/note_names/NoteNames.qml

View Options

src/activities/note_names/note_names.js

View Options

src/activities/playpiano/Playpiano.qml

Note names: Fixes and improvements 1. Implement reload button 2. Fix keyboard…7051c710aaaeActions

Description

Details

Changes (3)

R2:7051c710aaae

src/activities/note_names/NoteNames.qml

src/activities/note_names/note_names.js

src/activities/playpiano/Playpiano.qml

Note names: Fixes and improvements 1. Implement reload button 2. Fix keyboard…
7051c710aaae
Actions