Oware: Clean code and add twoPlayer mode

Authored by dmadaan on Jun 10 2017, 6:19 PM.

Description

Oware: Clean code and add twoPlayer mode

Details

Committed
dmadaanJun 10 2017, 6:19 PM
Parents
R2:6301716f7c16: core, move tutorial to core, apply it to nine_menmorris
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptJun 10 2017, 1:15 PM
jjazeix added inline comments.Jun 10 2017, 8:04 PM
/src/activities/oware/Oware.qml
89

if you know the type (int/string), use it directly instead of var

91

why changing it from value to hardcoded value?

/src/activities/oware/oware.js
90

so why don't you directly name it currentPlayer :)?

113

opponent (same typo below)