Oware: Minor fixes and additions 1. Added tutorial 2. Updated icon and renamed…

Authored by dmadaan on Jun 3 2017, 12:03 PM.

Description

Oware: Minor fixes and additions 1. Added tutorial 2. Updated icon and renamed images 3. Updated ActivityInfo

Details

Committed
dmadaanJun 3 2017, 12:03 PM
Parents
R2:b98233bead47: Oware: Initial design
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. · View Herald TranscriptJun 3 2017, 6:41 AM

you can remove the backup icon file.

qrc:/gcompris/src/activities/oware/Oware.qml:369:9: QML Image: Cannot open: qrc:/gcompris/src/activities/oware/resource/tutorial3.png

/src/activities/oware/ActivityInfo.qml
26

qsTr() there too ;). You can check the one from tools folder (and remove it after).

/src/activities/oware/Oware.qml
58

no need to shorten variable names (even for one letter)

142

I would not use images like in the Gtk+ version, but use a "simple" item.
The notify is not necessary too.

243

Would it be possible to have a TutorialWithImage item reusable? If I'm not wrong, it looks like a lot the one as in 9 men morris? If not possible, it would be nice to at least separate it in the separate file in the activity (you can put in it all the js functions you have defined in the oware.js file too).

It may be interesting to think of a vertical mode too