Minor fixes 1. Play background music on downloading 2. Fix configuration option
5b3d90190d31
Actions

Authored by dmadaan on Apr 29 2017, 1:16 AM.

Description

Minor fixes 1. Play background music on downloading 2. Fix configuration option

Committed

dmadaan

Apr 29 2017, 1:16 AM

Parents

R2:65a0ff6f0a5d: Add background music

Branches

Unknown

Tags

Unknown

Restricted Application added a subscriber: jjazeix. · View Herald TranscriptApr 28 2017, 7:54 PM

After checking what we wrote in the previous review:

The default value for the ApplicationSettings::m_isBackgroundMusicEnabled should be false.
Everytime you enter or leave an activity, there is a pop-up for download the music if not available.

Please check again to be sure to take in account all the remarks Holger and I did.

I didn't test yet with the rcc

/src/core/main.qml
112	use camelCase naming convention
130	Error registering resource file "" qrc:/gcompris/src/core/main.qml:132: TypeError: Property 'connect' of object false is not a function You should either add a backgroundMusicRegistered signal in DownloadManager or filter in playBackgroundMusic() to only enter when it is backgroundMusic that is registered and not every possible rcc

				Path	Packages
	M			src/activities/menu/ConfigurationItem.qml
	M			src/core/main.qml