Diffusion GCompris 38914aa30a23

Railroad, created a function for calculating uniqueId of sample wagons.
38914aa30a23
Actions

Authored by asagtani on Feb 12 2018, 11:56 AM.

Description

Railroad, created a function for calculating uniqueId of sample wagons.

Details

Committed
asagtaniFeb 12 2018, 11:56 AM
Parents
R2:c5557af667c5: Railroad, fixed wagons width for portrait mode
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptFeb 12 2018, 11:59 AM
jjazeix added inline comments.Feb 12 2018, 12:13 PM
/src/activities/railroad/railroad.js
43

there is still something bothering me :)
would it be clearer to have numberOfRows, numberOfColumns and use these numbers instead of 4, 6 and 20?

192

displayed

asagtani added inline comments.Feb 12 2018, 2:27 PM
/src/activities/railroad/railroad.js
43

yes, using numberOfRows = [4, 5, 4, 5...........] and
numberOfColumns = noOfWagons / noOfwagons would be more clearer and will remove some hardcoded values in qml file.

Changes (2)

PathPackages
Msrc/activities/railroad/Railroad.qml
Msrc/activities/railroad/railroad.js

R2:38914aa30a23

View Options

src/activities/railroad/Railroad.qml

Loading...
View Options

src/activities/railroad/railroad.js

Loading...