Convert enumeration MyMoneyReport::EColumnType into a class to be more type safe
1e5384157ca6
Actions

Authored by habacker on Mar 5 2018, 7:13 AM.

Description

Convert enumeration MyMoneyReport::EColumnType into a class to be more type safe

Type safety is increased by moving the enum into a separate name space (here
a class is used because namespaces are not allowed inside classes).

Q_ENUM(s) or QFlags could also not be used because the related enums need
to be defined somewhere outside, which does not solve the issue having all
constants in MyMoneyReport namespace.

CCBUG:391091

Test Plan: compiled on linux

Reviewers: KMyMoney

Reviewed By: KMyMoney, tbaumgart

Differential Revision: https://phabricator.kde.org/D11043

Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>

Details

Committed

habacker

Mar 7 2018, 9:46 AM

Reviewer

KMyMoney

Differential Revision

D11043: Convert enumeration MyMoneyReport::EColumnType into a class to be more type safe

Parents

R261:5fadc202afa2: Fix compiling with DEBUG_REPORTS enabled

Branches

Unknown

Tags

Unknown

habacker committed R261:1e5384157ca6: Convert enumeration MyMoneyReport::EColumnType into a class to be more type safe (authored by habacker).Mar 7 2018, 9:46 AM

tbaumgart mentioned this in D11163: Bring type safety to reports.Mar 8 2018, 10:00 PM

Changes (9)

				Path	Packages
	M			kmymoney/dialogs/kbalancechartdlg.cpp
	M			kmymoney/dialogs/kreportconfigurationfilterdlg.cpp
	M			kmymoney/mymoney/mymoneyreport.cpp
	M			kmymoney/mymoney/mymoneyreport.h
	M			kmymoney/reports/pivottable.cpp
	M			kmymoney/reports/pivottabletest.cpp
	M			kmymoney/views/kforecastview.cpp
	M			kmymoney/views/khomeview.cpp
	M			kmymoney/views/kreportsview.cpp