Fix crop ratio combobox not updating crop when text didn't change

Authored by huoni on Mar 22 2018, 12:55 AM.

Description

Fix crop ratio combobox not updating crop when text didn't change

Summary:
For example, "US Letter" is duplicated - one for landscape, one
for portrait. Since the crop was only updated when the combobox
text changed, switching between these two didn't do anything.
This patch adds a connection to the currentIndexChanged signal
so that changes like this are detected.

Depends on D11378

Test Plan:

  1. Open crop tool > Advanced settings
  2. Change Ratio to US Letter (portrait)
  3. Change Ratio to US Letter (landscape)
  4. Repeat for the ISO ratio

Reviewers: Gwenview, rkflx

Reviewed By: Gwenview, rkflx

Differential Revision: https://phabricator.kde.org/D11379

Details

Committed
huoniMar 22 2018, 11:43 AM
Reviewer
Gwenview
Differential Revision
D11379: Fix crop ratio combobox not updating crop when text didn't change
Parents
R260:c1e227f13af1: Save last used crop ratio settings
Branches
Unknown
Tags
Unknown