Don't use exec() to open dialogs

Authored by elvisangelaccio on Nov 7 2017, 6:28 PM.

Description

Don't use exec() to open dialogs

Summary:
exec() is blocking and should not be used if possible.

Currently it makes impossible to interact with a 2nd okular window
if the first window has the Properties or Embedded Files dialog open.

It also causes a double delete crash when closing okular via dbus
while either of those dialogs is open.

We can use open() instead which does not block the event loop and fixes
both the problems.

Test Plan:

  1. Open the Properties or Embedded Files dialog, then close okular via dbus.
  2. Open two okular windows, then open the Properties or Embedded Files dialog in one of them and try to use the other window.

Reviewers: Okular

Tags: Okular

Differential Revision: https://phabricator.kde.org/D8704

Details

Committed
elvisangelaccioNov 12 2017, 11:17 AM
Differential Revision
D8704: Don't use exec() to open dialogs
Parents
R223:a2f5560c0076: PDF: Support the poppler 0.62 renderToImage with update callback
Branches
Unknown
Tags
Unknown