Const'ify
9ab62fb867af
Actions

Authored by mlaurent on Jan 10 2019, 1:41 PM.

Description

Const'ify

Details

Committed

mlaurent

Jan 10 2019, 3:45 PM

Parents

R181:780105af6cf5: Add const'ref + use override

Branches

Unknown

Tags

Unknown

mlaurent committed R181:9ab62fb867af: Const'ify (authored by mlaurent).Jan 10 2019, 3:45 PM

heikobecker mentioned this in R181:7281ee31d844: Fix build after 9ab62fb867.Jan 11 2019, 8:24 AM

Changes (353)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path	Packages
	M			shared/tag_helpers/StringHelper.cpp
	M			shared/tag_helpers/StringHelper.h
	M			shared/tag_helpers/TagHelper.cpp
	M			shared/tag_helpers/TagHelper.h
	M			src/EngineController.cpp
	M			src/EngineController.h
	M			src/GlobalCollectionActions.cpp
	M			src/GlobalCollectionActions.h
	M			src/TrayIcon.cpp
	M			src/TrayIcon.h
	M			src/aboutdialog/ExtendedAboutDialog.cpp
	M			src/aboutdialog/ExtendedAboutDialog.h
	M			src/aboutdialog/OcsPersonItem.cpp
	M			src/aboutdialog/OcsPersonItem.h
	M			src/amarokurls/AmarokUrl.cpp
	M			src/amarokurls/AmarokUrl.h
	M			src/amarokurls/AmarokUrlHandler.cpp
	M			src/amarokurls/AmarokUrlHandler.h
	M			src/amarokurls/AmarokUrlRunnerBase.h
	M			src/amarokurls/BookmarkGroup.cpp
	M			src/amarokurls/BookmarkGroup.h
	M			src/amarokurls/BookmarkMetaActions.cpp
	M			src/amarokurls/BookmarkMetaActions.h
	M			src/amarokurls/BookmarkTreeView.cpp
	M			src/amarokurls/BookmarkTreeView.h
	M			src/amarokurls/ContextUrlRunner.cpp
	M			src/amarokurls/ContextUrlRunner.h
	M			src/amarokurls/NavigationUrlRunner.cpp
	M			src/amarokurls/NavigationUrlRunner.h
	M			src/amarokurls/PlayUrlGenerator.cpp
	M			src/amarokurls/PlayUrlGenerator.h
	M			src/amarokurls/PlayUrlRunner.cpp
	M			src/amarokurls/PlayUrlRunner.h
	M			src/browsers/CollectionTreeItem.cpp
	M			src/browsers/CollectionTreeItem.h
	M			src/browsers/CollectionTreeItemModel.cpp
	M			src/browsers/CollectionTreeItemModelBase.cpp
	M			src/browsers/CollectionTreeItemModelBase.h
	M			src/browsers/playlistbrowser/DynamicBiasDialog.cpp
	M			src/browsers/playlistbrowser/DynamicBiasDialog.h
	M			src/browsers/playlistbrowser/PlaylistBrowserModel.cpp
	M			src/browsers/playlistbrowser/PlaylistBrowserModel.h
	M			src/context/applets/albums/plugin/AlbumItem.cpp
	M			src/context/applets/albums/plugin/AlbumItem.h
	M			src/context/applets/albums/plugin/AlbumsEngine.cpp
	M			src/context/applets/albums/plugin/AlbumsEngine.h
	M			src/context/applets/albums/plugin/TrackItem.cpp
	M			src/context/applets/albums/plugin/TrackItem.h
	M			src/context/applets/photos/plugin/PhotosEngine.cpp
	M			src/context/applets/photos/plugin/PhotosEngine.h
	M			src/context/applets/wikipedia/plugin/WikipediaEngine.cpp
	M			src/context/applets/wikipedia/plugin/WikipediaEngine.h
	M			src/core-impl/capabilities/AlbumActionsCapability.cpp
	M			src/core-impl/capabilities/AlbumActionsCapability.h
	M			src/core-impl/capabilities/timecode/TimecodeWriteCapability.cpp
	M			src/core-impl/capabilities/timecode/TimecodeWriteCapability.h
	M			src/core-impl/collections/aggregate/AggregateCollection.cpp
	M			src/core-impl/collections/aggregate/AggregateCollection.h
	M			src/core-impl/collections/aggregate/AggregateMeta.cpp
	M			src/core-impl/collections/aggregate/AggregateMeta.h
	M			src/core-impl/collections/daap/DaapCollection.cpp
	M			src/core-impl/collections/daap/DaapCollection.h
	M			src/core-impl/collections/daap/DaapMeta.cpp
	M			src/core-impl/collections/daap/DaapMeta.h
	M			src/core-impl/collections/daap/daapreader/Reader.cpp
	M			src/core-impl/collections/daap/daapreader/Reader.h
	M			src/core-impl/collections/db/MountPointManager.h
	M			src/core-impl/collections/db/sql/SqlQueryMaker.cpp
	M			src/core-impl/collections/db/sql/SqlQueryMaker.h
	M			src/core-impl/collections/db/sql/SqlRegistry.cpp
	M			src/core-impl/collections/db/sql/SqlRegistry.h
	M			src/core-impl/collections/db/sql/device/massstorage/MassStorageDeviceHandler.cpp
	M			src/core-impl/collections/db/sql/device/massstorage/MassStorageDeviceHandler.h
	M			src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.cpp
	M			src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.h
	M			src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp
	M			src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.h
	M			src/core-impl/collections/db/sql/mysqlcollection/MySqlQueryMaker.cpp
	M			src/core-impl/collections/db/sql/mysqlcollection/MySqlQueryMaker.h
	M			src/core-impl/collections/ipodcollection/IpodCollection.cpp
	M			src/core-impl/collections/ipodcollection/IpodCollection.h
	M			src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp
	M			src/core-impl/collections/ipodcollection/IpodCollectionLocation.h
	M			src/core-impl/collections/ipodcollection/IpodPlaylist.cpp
	M			src/core-impl/collections/ipodcollection/IpodPlaylist.h
	M			src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp
	M			src/core-impl/collections/ipodcollection/IpodPlaylistProvider.h
	M			src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp
	M			src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h
	M			src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp
	M			src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h
	M			src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.cpp
	M			src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.h
	M			src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.cpp
	M			src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h
	M			src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp
	M			src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.h
	M			src/core-impl/collections/mediadevicecollection/podcast/MediaDevicePodcastProvider.cpp
	M			src/core-impl/collections/mediadevicecollection/podcast/MediaDevicePodcastProvider.h
	M			src/core-impl/collections/playdarcollection/PlaydarMeta.cpp
	M			src/core-impl/collections/playdarcollection/PlaydarMeta.h
	M			src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp
	M			src/core-impl/collections/playdarcollection/support/ProxyResolver.h
	M			src/core-impl/collections/playdarcollection/support/QMFunctionTypes.h
	M			src/core-impl/collections/playdarcollection/support/Query.h
	M			src/core-impl/collections/support/MemoryFilter.cpp
	M			src/core-impl/collections/support/MemoryFilter.h
	M			src/core-impl/collections/support/MemoryMatcher.cpp
	M			src/core-impl/collections/support/MemoryMatcher.h
	M			src/core-impl/collections/support/MemoryQueryMaker.cpp
	M			src/core-impl/collections/support/MemoryQueryMaker.h
	M			src/core-impl/collections/umscollection/UmsCollection.cpp
	M			src/core-impl/collections/umscollection/UmsCollection.h
	M			src/core-impl/collections/umscollection/UmsCollectionLocation.h
	M			src/core-impl/collections/umscollection/podcasts/UmsPodcastMeta.cpp
	M			src/core-impl/collections/umscollection/podcasts/UmsPodcastMeta.h
	M			src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp
	M			src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.h
	M			src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp
	M			src/core-impl/collections/upnpcollection/UpnpBrowseCollection.h
	M			src/core-impl/collections/upnpcollection/UpnpCache.cpp
	M			src/core-impl/collections/upnpcollection/UpnpCache.h
	M			src/core-impl/collections/upnpcollection/UpnpMemoryQueryMaker.cpp
	M			src/core-impl/collections/upnpcollection/UpnpMemoryQueryMaker.h
	M			src/core-impl/collections/upnpcollection/UpnpMeta.cpp
	M			src/core-impl/collections/upnpcollection/UpnpMeta.h
	M			src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp
	M			src/core-impl/collections/upnpcollection/UpnpQueryMaker.h
	M			src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.h
	M			src/core-impl/meta/cue/CueFileSupport.cpp
	M			src/core-impl/meta/cue/CueFileSupport.h
	M			src/core-impl/meta/multi/MultiTrack.cpp
	M			src/core-impl/meta/multi/MultiTrack.h
	M			src/core-impl/meta/proxy/MetaProxy.cpp
	M			src/core-impl/meta/proxy/MetaProxy.h
	M			src/core-impl/meta/proxy/MetaProxy_p.h
	M			src/core-impl/meta/stream/Stream_p.h
	M			src/core-impl/meta/timecode/TimecodeMeta.cpp
	M			src/core-impl/meta/timecode/TimecodeMeta.h
	M			src/core-impl/playlists/types/file/PlaylistFile.cpp
	M			src/core-impl/playlists/types/file/PlaylistFile.h
	M			src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp
	M			src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h
	M			src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp
	M			src/core-impl/podcasts/sql/PodcastSettingsDialog.h
	M			src/core-impl/podcasts/sql/SqlPodcastMeta.cpp
	M			src/core-impl/podcasts/sql/SqlPodcastMeta.h
	M			src/core-impl/podcasts/sql/SqlPodcastProvider.cpp
	M			src/core-impl/podcasts/sql/SqlPodcastProvider.h
	M			src/core-impl/storage/StorageManager.cpp
	M			src/core-impl/storage/StorageManager.h
	M			src/core-impl/support/TrackLoader.cpp
	M			src/core-impl/support/TrackLoader.h
	M			src/core/capabilities/ReadLabelCapability.h
	M			src/core/collections/CollectionLocation.cpp
	M			src/core/collections/CollectionLocation.h
	M			src/core/collections/QueryMaker.h
	M			src/core/meta/Observer.cpp
	M			src/core/meta/Observer.h
	M			src/core/meta/support/MetaUtility.cpp
	M			src/core/meta/support/MetaUtility.h
	M			src/core/meta/support/PrivateMetaRegistry.cpp
	M			src/core/meta/support/PrivateMetaRegistry.h
	M			src/core/playlists/Playlist.cpp
	M			src/core/playlists/Playlist.h
	M			src/core/playlists/PlaylistProvider.cpp
	M			src/core/playlists/PlaylistProvider.h
	M			src/core/podcasts/PodcastMeta.cpp
	M			src/core/podcasts/PodcastMeta.h
	M			src/core/podcasts/PodcastProvider.cpp
	M			src/core/podcasts/PodcastProvider.h
	M			src/core/transcoding/TranscodingProperty.cpp
	M			src/core/transcoding/TranscodingProperty.h
	M			src/covermanager/CoverFetchQueue.cpp
	M			src/covermanager/CoverFetchQueue.h
	M			src/covermanager/CoverFetchUnit.cpp
	M			src/covermanager/CoverFetchUnit.h
	M			src/covermanager/CoverFetcher.cpp
	M			src/covermanager/CoverFetcher.h
	M			src/covermanager/CoverFetchingActions.h
	M			src/covermanager/CoverFoundDialog.cpp
	M			src/covermanager/CoverFoundDialog.h
	M			src/covermanager/CoverManager.cpp
	M			src/covermanager/CoverManager.h
	M			src/databaseimporter/SqlBatchImporter.cpp
	M			src/databaseimporter/SqlBatchImporter.h
	M			src/dbus/mpris1/PlayerHandler.cpp
	M			src/dbus/mpris1/PlayerHandler.h
	M			src/dbus/mpris2/MediaPlayer2Player.cpp
	M			src/dbus/mpris2/MediaPlayer2Player.h
	M			src/dialogs/DatabaseImporterDialog.cpp
	M			src/dialogs/DatabaseImporterDialog.h
	M			src/dialogs/DiagnosticDialog.cpp
	M			src/dialogs/DiagnosticDialog.h
	M			src/dialogs/LabelListModel.cpp
	M			src/dialogs/LabelListModel.h
	M			src/dialogs/TagDialog.cpp
	M			src/dialogs/TagDialog.h
	M			src/dynamic/Bias.cpp
	M			src/dynamic/Bias.h
	M			src/dynamic/BiasSolver.cpp
	M			src/dynamic/BiasSolver.h
	M			src/dynamic/BiasedPlaylist.cpp
	M			src/dynamic/BiasedPlaylist.h
	M			src/dynamic/DynamicModel.cpp
	M			src/dynamic/DynamicModel.h
	M			src/dynamic/DynamicPlaylist.cpp
	M			src/dynamic/DynamicPlaylist.h
	M			src/dynamic/TrackSet.cpp
	M			src/dynamic/TrackSet.h
	M			src/dynamic/biases/AlbumPlayBias.cpp
	M			src/dynamic/biases/AlbumPlayBias.h
	M			src/dynamic/biases/EchoNestBias.cpp
	M			src/dynamic/biases/EchoNestBias.h
	M			src/dynamic/biases/IfElseBias.cpp
	M			src/dynamic/biases/IfElseBias.h
	M			src/dynamic/biases/PartBias.cpp
	M			src/dynamic/biases/PartBias.h
	M			src/dynamic/biases/QuizPlayBias.cpp
	M			src/dynamic/biases/QuizPlayBias.h
	M			src/dynamic/biases/SearchQueryBias.cpp
	M			src/dynamic/biases/SearchQueryBias.h
	M			src/dynamic/biases/TagMatchBias.cpp
	M			src/dynamic/biases/TagMatchBias.h
	M			src/importers/ImporterManager.cpp
	M			src/importers/ImporterManager.h
	M			src/lyrics/LyricsManager.cpp
	M			src/lyrics/LyricsManager.h
	M			src/musicbrainz/MusicBrainzTagsItem.cpp
	M			src/musicbrainz/MusicBrainzTagsItem.h
	M			src/musicbrainz/MusicBrainzTagsModel.cpp
	M			src/musicbrainz/MusicBrainzTagsModel.h
	M			src/playlist/PlaylistItem.cpp
	M			src/playlist/PlaylistItem.h
	M			src/playlist/PlaylistModel.cpp
	M			src/playlist/PlaylistModel.h
	M			src/playlist/PlaylistRestorer.cpp
	M			src/playlist/PlaylistRestorer.h
	M			src/playlist/PlaylistSortWidget.cpp
	M			src/playlist/PlaylistSortWidget.h
	M			src/playlist/PlaylistViewUrlRunner.cpp
	M			src/playlist/PlaylistViewUrlRunner.h
	M			src/playlist/ProgressiveSearchWidget.h
	M			src/playlist/layouts/LayoutEditWidget.cpp
	M			src/playlist/layouts/LayoutEditWidget.h
	M			src/playlist/layouts/LayoutItemConfig.cpp
	M			src/playlist/layouts/LayoutItemConfig.h
	M			src/playlist/navigators/DynamicTrackNavigator.cpp
	M			src/playlist/navigators/DynamicTrackNavigator.h
	M			src/playlist/proxymodels/AbstractModel.h
	M			src/playlist/proxymodels/ProxyBase.cpp
	M			src/playlist/proxymodels/ProxyBase.h
	M			src/playlist/proxymodels/SortFilterProxy.cpp
	M			src/playlist/proxymodels/SortFilterProxy.h
	M			src/playlist/view/listview/PrettyItemDelegate.cpp
	M			src/playlist/view/listview/PrettyItemDelegate.h
	M			src/playlistgenerator/ConstraintSolver.cpp
	M			src/playlistgenerator/ConstraintSolver.h
	M			src/playlistgenerator/PresetEditDialog.cpp
	M			src/playlistgenerator/PresetEditDialog.h
	M			src/playlistgenerator/PresetModel.cpp
	M			src/playlistgenerator/PresetModel.h
	M			src/playlistgenerator/constraints/TagMatch.h
	M			src/playlistgenerator/constraints/TagMatchSupport.cpp
	M			src/playlistmanager/SyncedPlaylist.cpp
	M			src/playlistmanager/SyncedPlaylist.h
	M			src/playlistmanager/SyncedPodcast.h
	M			src/playlistmanager/file/PlaylistFileProvider.cpp
	M			src/playlistmanager/file/PlaylistFileProvider.h
	M			src/playlistmanager/sql/SqlPlaylist.cpp
	M			src/playlistmanager/sql/SqlPlaylist.h
	M			src/playlistmanager/sql/SqlPlaylistGroup.cpp
	M			src/playlistmanager/sql/SqlPlaylistGroup.h
	M			src/playlistmanager/sql/SqlUserPlaylistProvider.cpp
	M			src/playlistmanager/sql/SqlUserPlaylistProvider.h
	M			src/scanner/GenericScannerJob.cpp
	M			src/scanner/GenericScannerJob.h
	M			src/scripting/scriptengine/AmarokBookmarkScript.cpp
	M			src/scripting/scriptengine/AmarokBookmarkScript.h
	M			src/scripting/scriptengine/AmarokEqualizerScript.cpp
	M			src/scripting/scriptengine/AmarokEqualizerScript.h
	M			src/scripting/scriptengine/AmarokNetworkScript.cpp
	M			src/scripting/scriptengine/AmarokNetworkScript.h
	M			src/scripting/scriptengine/AmarokPlaylistScript.cpp
	M			src/scripting/scriptengine/AmarokPlaylistScript.h
	M			src/scripting/scriptengine/AmarokStreamItemScript.cpp
	M			src/scripting/scriptengine/AmarokStreamItemScript.h
	M			src/scripting/scriptengine/AmarokWindowScript.cpp
	M			src/scripting/scriptengine/AmarokWindowScript.h
	M			src/scripting/scriptengine/exporters/CollectionTypeExporter.cpp
	M			src/scripting/scriptengine/exporters/CollectionTypeExporter.h
	M			src/scripting/scriptengine/exporters/MetaTypeExporter.cpp
	M			src/scripting/scriptengine/exporters/MetaTypeExporter.h
	M			src/scripting/scriptengine/exporters/PlaylistExporter.cpp
	M			src/scripting/scriptengine/exporters/PlaylistExporter.h
	M			src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp
	M			src/scripting/scriptengine/exporters/ScriptableBiasExporter.h
	M			src/scripting/scriptmanager/ScriptManager.cpp
	M			src/scripting/scriptmanager/ScriptManager.h
	M			src/services/InfoParserBase.h
	M			src/services/ServiceCollection.cpp
	M			src/services/ServiceCollection.h
	M			src/services/ServiceMetaBase.cpp
	M			src/services/ServiceMetaBase.h
	M			src/services/ServiceSqlCollection.cpp
	M			src/services/ServiceSqlCollection.h
	M			src/services/ServiceSqlQueryMaker.cpp
	M			src/services/ServiceSqlQueryMaker.h
	M			src/services/ampache/AmpacheAccountLogin.cpp
	M			src/services/ampache/AmpacheAccountLogin.h
	M			src/services/ampache/AmpacheServiceCollection.cpp
	M			src/services/ampache/AmpacheServiceCollection.h
	M			src/services/ampache/AmpacheServiceQueryMaker.cpp
	M			src/services/ampache/AmpacheServiceQueryMaker.h
	M			src/services/ampache/LastfmInfoParser.cpp
	M			src/services/ampache/LastfmInfoParser.h
	M			src/services/gpodder/GpodderPodcastRequestHandler.cpp
	M			src/services/gpodder/GpodderPodcastRequestHandler.h
	M			src/services/gpodder/GpodderProvider.cpp
	M			src/services/gpodder/GpodderProvider.h
	M			src/services/gpodder/GpodderTreeItem.cpp
	M			src/services/gpodder/GpodderTreeItem.h
	M			src/services/magnatune/MagnatuneDatabaseWorker.h
	M			src/services/magnatune/MagnatuneDownloadDialog.h
	M			src/services/magnatune/MagnatuneInfoParser.cpp
	M			src/services/magnatune/MagnatuneInfoParser.h
	M			src/services/magnatune/MagnatuneMeta.cpp
	M			src/services/magnatune/MagnatuneMeta.h
	M			src/services/magnatune/MagnatuneRedownloadDialog.h
	M			src/services/magnatune/MagnatuneStore.cpp
	M			src/services/magnatune/MagnatuneStore.h
	M			src/services/magnatune/MagnatuneUrlRunner.cpp
	M			src/services/magnatune/MagnatuneUrlRunner.h
	M			src/services/opmldirectory/OpmlDirectoryInfoParser.cpp
	M			src/services/opmldirectory/OpmlDirectoryInfoParser.h
	M			src/services/opmldirectory/OpmlDirectoryService.cpp
	M			src/services/opmldirectory/OpmlDirectoryService.h
	M			src/services/scriptable/ScriptableServiceInfoParser.cpp
	M			src/services/scriptable/ScriptableServiceInfoParser.h
	M			src/services/scriptable/ScriptableServiceQueryMaker.cpp
	M			src/services/scriptable/ScriptableServiceQueryMaker.h
	M			src/statsyncing/Config.cpp
	M			src/statsyncing/Controller.cpp
	M			src/statsyncing/Controller.h
	M			src/statsyncing/ProviderFactory.h
	M			src/statsyncing/collection/CollectionTrack.h
	M			src/widgets/BookmarkTriangle.cpp
	M			src/widgets/BookmarkTriangle.h
	M			src/widgets/Osd.cpp
	M			src/widgets/Osd.h
	M			tests/core-impl/meta/multi/TestMetaMultiTrack.h
	M			utilities/afttagger/AFTTagger.cpp
	M			utilities/afttagger/AFTTagger.h