Diffusion Spectacle 1d2e24ace9f3

Now it's not experimental
Concern Raised1d2e24ace9f3
Actions

Authored by mlaurent on Jan 18 2018, 6:06 AM.

Description

Now it's not experimental

Details

Auditors
rkflx
Committed
mlaurentJan 18 2018, 6:06 AM
Parents
R166:571e07cd3633: Fix keyboard shortcut version
Branches
Unknown
Tags
Unknown
rkflx raised a concern with this commit.Feb 20 2018, 6:19 PM
rkflx added a project: Spectacle.
rkflx added a subscriber: rkflx.

Thanks for fixing this, but this broke cmake on older distros. Could you make it so that when KF5::PurposeWidgets is not found it falls back trying to locate KDEExperimental::PurposeWidgets?

I don't really want to bump KF5_MIN_VERSION (unless KDE Applications requires us to do this?), because this way it is easier for new contributors on older distros to get started.

/src/CMakeLists.txt
98

Would it make sense to rename this too?

This commit now has outstanding concerns.Feb 20 2018, 6:19 PM

Changes (1)

PathPackages
Msrc/CMakeLists.txt

R166:1d2e24ace9f3

View Options

src/CMakeLists.txt

Loading...