[server] Improve the handling when clients disconnect
fd01e59a5fca
Actions

Authored by graesslin on May 19 2016, 1:17 PM.

Description

[server] Improve the handling when clients disconnect

Summary:
So far the server component performed manual cleanup in some cases
when a client disconnects. But this is not needed: the Wayland library
calls the static unbind methods which do cleanup. If we cleanup ourselves
this can result in double deletes in the worst case, so let's only use
the Wayland functionality.

Adjusted:

RegionInterface
SurfaceInterface
ShellSurfaceInterface (doesn't take a parent anymore)
DpmsInterface
QtSurfaceExtensionInterface
KeyboardInterface
PointerInterface
TouchInterface
DataOfferInterface
PlasmaShellSurfaceInterface

For each adjusted case a test case is added to verify that the cleanup
works. Exceptions are DpmsInterface as the actual Resource is not exposed
at all in the Server component and DataOfferInterface as that is server
side created.

Reviewers: Plasma

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D1640

Details

Committed

graesslin

May 19 2016, 2:21 PM

Differential Revision

D1640: [server] Improve the handling when clients disconnect

Parents

R127:502795573a70: [autotests] Longer wait in TestWaylandOutputDevice::testId

Branches

Unknown

Tags

Unknown

graesslin committed R127:fd01e59a5fca: [server] Improve the handling when clients disconnect (authored by graesslin).May 19 2016, 2:21 PM

Changes (16)

				Path	Packages
	M			autotests/client/test_plasmashell.cpp
	M			autotests/client/test_wayland_region.cpp
	M			autotests/client/test_wayland_seat.cpp
	M			autotests/client/test_wayland_shell.cpp
	M			autotests/client/test_wayland_surface.cpp
	M			autotests/server/test_qt_surface_extension.cpp
	M			src/server/compositor_interface.cpp
	M			src/server/dataoffer_interface.cpp
	M			src/server/dpms_interface.cpp
	M			src/server/keyboard_interface.cpp
	M			src/server/plasmashell_interface.cpp
	M			src/server/pointer_interface.cpp
	M			src/server/qtsurfaceextension_interface.cpp
	M			src/server/region_interface.cpp
	M			src/server/shell_interface.cpp
	M			src/server/touch_interface.cpp

[server] Improve the handling when clients disconnectfd01e59a5fcaActions

Description

Details

Changes (16)

R127:fd01e59a5fca

autotests/client/test_plasmashell.cpp

autotests/client/test_wayland_region.cpp

autotests/client/test_wayland_seat.cpp

autotests/client/test_wayland_shell.cpp

autotests/client/test_wayland_surface.cpp

autotests/server/test_qt_surface_extension.cpp

src/server/compositor_interface.cpp

src/server/dataoffer_interface.cpp

src/server/dpms_interface.cpp

src/server/keyboard_interface.cpp

src/server/plasmashell_interface.cpp

src/server/pointer_interface.cpp

src/server/qtsurfaceextension_interface.cpp

src/server/region_interface.cpp

src/server/shell_interface.cpp

src/server/touch_interface.cpp

[server] Improve the handling when clients disconnect
fd01e59a5fca
Actions