[server] Standardize the destructor request handling for Resources
03594de1d730
Actions

Authored by graesslin on May 25 2016, 8:04 AM.

Description

[server] Standardize the destructor request handling for Resources

Summary:
This change standardizes the behavior regarding the destructor request.

The destructor should destroy the resource and nothing else. The
Wayland library invokes the static unbind method once the resource is
destroyed. The implementation provided by Resource::Private::unbind
triggers a delete later on the Resource. So there is no need to trigger
a deleteLater from the destructor request callback.

This change adds a generic implementation to Resource::Private which is
now used by all inheriting classes replacing the custom implementations.

Test Plan:
For a few Resources the test is extended to ensure that the Resource
gets deleted on server side.

Reviewers: Plasma

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D1679

Details

Committed

graesslin

May 30 2016, 6:16 AM

Differential Revision

D1679: [server] Standardize the destructor request handling for Resources

Parents

R127:59bdc94526cd: [server] Don't destroy resource from dtor of a Resource sub class

Branches

Unknown

Tags

Unknown

graesslin committed R127:03594de1d730: [server] Standardize the destructor request handling for Resources (authored by graesslin).May 30 2016, 6:16 AM

Changes (24)

				Path	Packages
	M			autotests/client/test_datadevice.cpp
	M			autotests/client/test_server_side_decoration.cpp
	M			autotests/client/test_wayland_blur.cpp
	M			autotests/client/test_wayland_contrast.cpp
	M			src/server/blur_interface.cpp
	M			src/server/contrast_interface.cpp
	M			src/server/datadevice_interface.cpp
	M			src/server/dataoffer_interface.cpp
	M			src/server/datasource_interface.cpp
	M			src/server/dpms_interface.cpp
	M			src/server/dpms_interface_p.h
	M			src/server/idle_interface.cpp
	M			src/server/plasmashell_interface.cpp
	M			src/server/region_interface.cpp
	M			src/server/resource.cpp
	M			src/server/resource_p.h
	M			src/server/server_decoration_interface.cpp
	M			src/server/subcompositor_interface.cpp
	M			src/server/subsurface_interface_p.h
	M			src/server/surface_interface.cpp
	M			src/server/surface_interface_p.h
	M			src/server/textinput_interface.cpp
	M			src/server/textinput_interface_p.h
	M			src/server/textinput_interface_v2.cpp

[server] Standardize the destructor request handling for Resources03594de1d730Actions

Description

Details

Changes (24)

R127:03594de1d730

autotests/client/test_datadevice.cpp

autotests/client/test_server_side_decoration.cpp

autotests/client/test_wayland_blur.cpp

autotests/client/test_wayland_contrast.cpp

src/server/blur_interface.cpp

src/server/contrast_interface.cpp

src/server/datadevice_interface.cpp

src/server/dataoffer_interface.cpp

src/server/datasource_interface.cpp

src/server/dpms_interface.cpp

src/server/dpms_interface_p.h

src/server/idle_interface.cpp

src/server/plasmashell_interface.cpp

src/server/region_interface.cpp

src/server/resource.cpp

src/server/resource_p.h

src/server/server_decoration_interface.cpp

src/server/subcompositor_interface.cpp

src/server/subsurface_interface_p.h

src/server/surface_interface.cpp

src/server/surface_interface_p.h

src/server/textinput_interface.cpp

src/server/textinput_interface_p.h

src/server/textinput_interface_v2.cpp

[server] Standardize the destructor request handling for Resources
03594de1d730
Actions