[Notes] Fix icons being almost invisible with light backgrounds when using dark…

Authored by filipf on May 4 2019, 8:59 PM.

Description

[Notes] Fix icons being almost invisible with light backgrounds when using dark themes

Summary:
Old code had no way to adapt icon colors based on background so this patch uses different components to color the icons black with light backgrounds, and white with dark backgrounds.

Because Plasma Components 2.0 ToolButton doesn't support icon colors and because with 3.0 the code doesn't work, we have to port the affected buttons to QQC2 ToolButton.

BUG: 353819
FIXED-IN: 5.17

Test Plan:
Before:

After:

NOTE: The buttons stay highlighted after being pressed, but I'm trying to solve that in D21026

Reviewers: Plasma, VDG, ngraham, davidedmundson

Reviewed By: Plasma, VDG, ngraham, davidedmundson

Subscribers: broulik, davidedmundson, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D21027

Details

Committed
filipfJun 21 2019, 9:38 AM
Reviewer
Plasma
Differential Revision
D21027: [Notes] Fix icons being almost invisible with light backgrounds when using dark themes
Parents
R114:db8fbc19bd9c: Add gitignore
Branches
Unknown
Tags
Unknown