Diffusion KWin e38ecfcbcfe4

[effects/slide] Completely delete forced roles

Authored by zzag on Jun 10 2018, 8:39 PM.

Description

[effects/slide] Completely delete forced roles

Summary:
The slide effect doesn't completely remove forced blur and background
contrast roles. According to EffectWindow::setData implementation,

void EffectWindowImpl::setData(int role, const QVariant &data)
{
    if (!data.isNull())
        dataMap[ role ] = data;
    else
        dataMap.remove(role);
    emit effects->windowDataChanged(this, role);
}

in order to delete previously set data, we should pass a null variant.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D13470

Details

Committed
zzagJun 11 2018, 12:32 PM
Reviewer
KWin
Differential Revision
D13470: [effects/slide] Completely delete forced roles
Parents
R108:1a1845b7d757: [effects/slide] Use FormLayout in KCM
Branches
Unknown
Tags
Unknown