Diffusion KWin d167935157e6

Add addToplevel and removeToplevel to Scene

Authored by zzag on Jan 11 2019, 6:55 PM.

Description

Add addToplevel and removeToplevel to Scene

Summary:
Code that destroys all scene windows when finishing compositing is not
readable. E.g. can you tell what this piece of code is doing without
looking into the source code of Scene::windowClosed?

foreach (Client * c, Workspace::self()->clientList())
    m_scene->windowClosed(c, NULL);

This change intoduces removeToplevel(as well its counterpart) method to
the Scene class. The name of the new method much better describes what
we're doing.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D18210

Details

Committed
zzagFeb 14 2019, 12:43 PM
Reviewer
KWin
Differential Revision
D18210: Add addToplevel and removeToplevel to Scene
Parents
R108:96a02c756092: [effects/logout] Hide configure button in Desktop Effects KCM
Branches
Unknown
Tags
Unknown