Diffusion KWin 2211a951e795

[kcmkwin] Split out Desktop Effects KCM

Authored by zzag on Feb 2 2019, 8:49 PM.

Description

[kcmkwin] Split out Desktop Effects KCM

Summary:
A while ago desktop effects and compositing settings lived under the
same roof

but time has passed and now those two have their own kcms. This causes
some issues:

  • for newcomers it's harder to find code of the Desktop Effects KCM;
  • git history doesn't look good, e.g. "[kcmkwin/compositing] Add some bugs to Desktop Effects KCM to fix later";
  • in general, the mix of two doesn't look good in the code.

This change splits out the Desktop Effects KCM. Unfortunately, in order
to have more nicer code I had to refactor EffectModel a little bit.

Before:

After:

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: davidedmundson, ltoscano, mart, ngraham, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D18703

Details

Committed
zzagMar 18 2019, 11:08 AM
Reviewer
KWin
Differential Revision
D18703: [kcmkwin] Split out Desktop Effects KCM
Parents
R108:5eb28512dd07: Use new window decoration theme icon for the Window Decorations KCM
Branches
Unknown
Tags
Unknown