Diffusion KWin 1193e3c3692a

Correctly check forcebackgroundcontrastrule

Authored by davidedmundson on Jun 11 2018, 9:41 AM.

Description

Correctly check forcebackgroundcontrastrule

Summary:
WindowBackgroundContrastRole property is a bool or undefined.

QVariant::isValid() returns true for QVariant(false) which is not what
we want for this code.

toBool on an invalid QVariant will return false.

Test Plan:
NA. Was based on code review.
To get a bug you'd have to PresentWindows/Slide effect manipulate a sliding popup, which
AFAIK doesn't happen.

Reviewers: KWin

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D13478

Details

Committed
davidedmundsonJun 11 2018, 9:44 AM
Differential Revision
D13478: Correctly check forcebackgroundcontrastrule
Parents
R108:5b4eb80c8fdb: Set specific edge cursor shape when resizing
Branches
Unknown
Tags
Unknown