Fix extraction of selected files when paths are not preserved
AbandonedPublic

Authored by elvisangelaccio on Feb 21 2016, 12:27 PM.

Details

Reviewers
rthomsen
Summary

CliInterface::moveToFinalDest has been introduced to fix drag-and-drop
extractions, where the "PreservePaths" options is always manually enabled. So this method
assumes that this option is always true.

However this is not the case when the user selects a bunch of files and
extracts them using the extraction dialog, where (s)he could disable the
PreservePaths option.

So, in order to enable extraction to a temp dir, it's not enough to just check
whether the user is extracting the whole archive or only some files of the
archive. We also need the check whether the PreservePaths options has been
disabled. This cannot happen with drag-and-drop extractions, so if this option
is false, we don't bother with extracting to a temp directory.

BUG: 359628

Diff Detail

Repository
R36 Ark
Branch
bug/359628
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio retitled this revision from to Fix extraction of selected files when paths are not preserved.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptFeb 21 2016, 12:27 PM

I've come up with a unit test which reproduces the bug and passes if I apply this commit. So I'd say that it's safe to commit this :)

elvisangelaccio abandoned this revision.Feb 29 2016, 3:04 PM

Superseded by commit c401afe.