Remember expanded status of tree view in statistics main window
ClosedPublic

Authored by hriesenbeck on Jan 16 2018, 8:36 PM.

Details

Summary

The collapsed tree view items of LessonStatisticsView were safed in
parleys config file. With this stored lesson names the expanded status
of the tree items will be restored when StatisticsMainWindow is
displayed next time.

Diff Detail

Repository
R340 Parley
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hriesenbeck created this revision.Jan 16 2018, 8:36 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 16 2018, 8:36 PM
hriesenbeck requested review of this revision.Jan 16 2018, 8:36 PM
aacid added a subscriber: aacid.Jan 16 2018, 9:53 PM
aacid added inline comments.
src/statistics/lessonstatisticsview.h
33

safe -> save

  • Fixed typo
hriesenbeck marked an inline comment as done.Jan 17 2018, 7:32 PM
hriesenbeck added inline comments.
src/statistics/lessonstatisticsview.h
33

Seems that I should some English lessons with Parley instead of hacking its code ;-)

Code looks reasonable and seems to work.

I'm not a Parley expert but i don't know if we have many left (besides maybe you=).

So if noone disagrees (or approves earlier) i'll approve this next week.

aacid accepted this revision.Thu, Jan 25, 7:39 AM
This revision is now accepted and ready to land.Thu, Jan 25, 7:39 AM
This revision was automatically updated to reflect the committed changes.