Differential D9910

calendar, fixed unexpected behaviour on answer submission by keyboard
ClosedPublic
Actions

Authored by asagtani on Jan 16 2018, 8:49 AM.

Details

Reviewers
jjazeix

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
asagtani created this revision.Jan 16 2018, 8:49 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 16 2018, 8:49 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
asagtani requested review of this revision.Jan 16 2018, 8:49 AM
jjazeix added a comment.Jan 16 2018, 11:54 AM

shouldn't there be the same in the answerChoices GridView?

asagtani updated this revision to Diff 25465.Jan 16 2018, 2:11 PM
jjazeix accepted this revision.Jan 16 2018, 8:40 PM

commited in https://commits.kde.org/gcompris/d2e252ef5ad065e4db2cb73d04e99e1594d73bf8.
I put the first if in a single if statement (if(event.key === ... && okButtonMouseArea.enabled)) and I fixed in ChoiceTable.qml (along with removing unused objects)
Thanks

This revision is now accepted and ready to land.Jan 16 2018, 8:40 PM
jjazeix closed this revision.Jan 16 2018, 8:40 PM

Revision Contents
Changeset List

PathPackages
Msrc/activities/calendar/Calendar.qml (16 lines)

Diff 25465

View Options

src/activities/calendar/Calendar.qml

Loading...