Remove redundant changeLog field
ClosedPublic

Authored by ngraham on Jan 13 2018, 4:25 AM.

Details

Summary

BUG: 387041
FIXED-IN: 5.12.0

For Debian packages, PackageKit manufactures the updateText and updates fields from the package's changelog. PackageKit gives us the updateText and updates fields, but also includes the original text used to synthesize them in a field called changeLog.

So we should only display updateText and updates, since changeLog is just the the raw information used to synthesize them, and if we show it too, there's duplicate information.

For more information about this, see https://github.com/hughsie/PackageKit/issues/227

Test Plan

This change needs testing from people who are not using Debian-based distros to make sure it didn't break anything for them!

I tested in KDE Neon, a Debian-based distro. Before:

After:

Other entries still show up and are not affected.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 13 2018, 4:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 13 2018, 4:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 13 2018, 4:25 AM
ngraham edited the summary of this revision. (Show Details)Jan 13 2018, 4:26 AM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the summary of this revision. (Show Details)Jan 13 2018, 5:19 AM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 25291.Jan 13 2018, 11:32 PM

Rename Discover's "Home" page to "Featured Apps"

ngraham updated this revision to Diff 25292.Jan 13 2018, 11:36 PM

Revert unintentional addition

apol accepted this revision.Jan 14 2018, 8:22 PM

On ArchLinux the changelog field is empty/unused.

This revision is now accepted and ready to land.Jan 14 2018, 8:22 PM
This revision was automatically updated to reflect the committed changes.