Differential D9818

[Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current
ClosedPublic
Actions

Authored by broulik on Jan 11 2018, 2:29 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:3b4be6568579: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current
Summary

The delete button changes the currentIndex to something else when deleting the current image but that didn't update cfg_Image. Just listen to when we become current. Might also fix keyboard navigation (didn't test if that worked before but it certainly does now).

BUG: 388805

Test Plan

Clicked another image, it got selected, Apply applied it.
Clicked an image, deleted it, another image got selected, Apply was enabled and applied it.
Verified that the Apply button is disabled when opening the dialog

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 11 2018, 2:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2018, 2:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 11 2018, 2:29 PM
davidedmundson accepted this revision.Jan 11 2018, 2:34 PM
This revision is now accepted and ready to land.Jan 11 2018, 2:34 PM
Closed by commit R120:3b4be6568579: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current (authored by broulik). · Explain WhyJan 11 2018, 2:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25161

View Options

wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml

Loading...