When we use the avg, it's very easy to "boost" the "right speaker" over 100%.
Before this patch, if you set the left channel to 50% and leave the right channel at 100% (via pavucontrol), the "master channel" will be the average of 75%. If you then raise the "master channel" by 10%, you raise the right channel to 110%.
Bug: 388553
https://bugs.kde.org/show_bug.cgi?id=388553
Before: https://streamable.com/2kp7m
After: https://streamable.com/5n56s
Installed pavucontrol. Unlocked the channels. See "After" video.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Well, this was actually intended to work like that. In case of split channels, I would say "avg" describes the merged volume better than "max", because with "max" you can have situation where one channel is 0%, second is 100% and merged volume now shows 100% which is wrong (is it?).
one channel is 0%, second is 100% and merged volume now shows 100%
If you lower the volume on a speaker, you care more about what the volume of the louder speaker is. It's weird if the OSD shows 50% when the right speaker is blaring at 100% and annoying my neighbours. You'd need to do mental math that the right speaker is +50% (or whatever it is).
Most OSes usually have a master channel slider, and a second slider for the left/right balance.
Correct me if I'm wrong, but I believe a "Left <-> Right" channel balance slider means at least 1 channel is always at a 100% ratio of the master volume. Since the center means both speakers are at 100%.
This means the "master volume" represents the "max" of all the channels.
Yes I do. Sorry I didn't get to push it yesterday. Thanks for approving the change!
Hmm, it seems the bot didn't recognize "Bug: 388553" in the commit message. Looks like I need to remember to use all caps next time "BUG: 388553".