Differential D9655

[Kickoff] Hide tab bar if only one tab button is configured
ClosedPublic
Actions

Authored by broulik on Jan 4 2018, 1:42 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Commits
R119:cc0e08dc8846: [Kickoff] Hide tab bar if only one tab button is configured
Summary

In Kickoff you can re-arrange and hide individual tab buttons.
If you remove all but one the tab bar becomes pointless.

BUG: 384757
FIXED-IN: 5.12.0

Test Plan

Removed all but the Favorite tab

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 4 2018, 1:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2018, 1:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 4 2018, 1:42 PM
davidedmundson accepted this revision.Jan 4 2018, 6:42 PM
davidedmundson added a subscriber: davidedmundson.

Could we use tabBar.layout.children.length directly in the state instead of a new property?

This revision is now accepted and ready to land.Jan 4 2018, 6:42 PM
broulik added a comment.Jan 4 2018, 6:44 PM

That's what I originally had but didn't work

Closed by commit R119:cc0e08dc8846: [Kickoff] Hide tab bar if only one tab button is configured (authored by broulik). · Explain WhyJan 5 2018, 9:24 AM
This revision was automatically updated to reflect the committed changes.
broulik edited the summary of this revision. (Show Details)Jan 5 2018, 9:28 AM

Revision Contents
Changeset List

Diff 24759

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...