⚙ D9646 Add autotest for roommodel and user classes

velurimithun added inline comments.Jan 3 2018, 7:12 PM

autotests/roommodeltest.cpp
54	check with selected 'true' (3rd arugument)

mlaurent added inline comments.Jan 4 2018, 6:06 AM

autotests/roommodeltest.cpp
65	if it creates a crash/error we need to fix it in roommodel
88	delete it at the end of method
93	Cache this value as const QString name = QStringLiteral("newName") so you can verify it easyly QCOMPARE(name, sampleWrapper->name());
100	QVERIFY(samepl->readOnly());

mlaurent requested changes to this revision.Jan 4 2018, 6:06 AM

This revision now requires changes to proceed.Jan 4 2018, 6:06 AM

Change updateRoom method in roomModel and add tests for roomModel

previous updateRomm method in roomModel(QJsonObject) was changing with name, now roomId is considered for change.

add tests for updateSubcription

clarity on updateRoom(QJsonObject)

can you please tell me exactly what updateRoom should do in roomModel.cpp?
It should update the existing values or It should update the existing values and add new values passed through arguments.

diff b/w "updated" case and "changed" in roomModel.cpp??

autotests/roommodeltest.cpp
140	Here it readOnly is true by default! Although we didn't mention it in QJsonObject.
165	Since, this is a new roomId which is not added -> it should not be removed.

Add test cases for user

velurimithun added inline comments.Jan 5 2018, 2:52 AM

autotests/usertest.cpp
45	unable to define user class on stack -> User *u; Error

Add more tests to user and roomModel

velurimithun added inline comments.Jan 5 2018, 5:10 AM

autotests/usertest.cpp
137	Here I think there is no need to check nameChanged and statusChagned signals since all those were checked earlier!

mlaurent requested changes to this revision.Jan 5 2018, 6:08 AM

mlaurent added inline comments.

autotests/rocketchataccountsettingstest.cpp
69 ↗	(On Diff #24748)	Same
autotests/rocketchataccountsettingstest.h
50 ↗	(On Diff #24748)	why you add theses changes in this review §?
autotests/roommodeltest.cpp
65	So ? do you still have error ?
102	Same for name as you use it all the time create a variable for it
110	it's better to compare "variable" to value > QCompare(spy.count(), 1)
130	Fails ? which is the problem ?
131	same QCompare(value, 1); fix all others QCOMPARE if necessary it's value compare with expected when it failed you can see correct debug
165	you still use input.append(QJsonValue(QLatin1String("removed"))); so it's correct no. If it found "removed" it will remove it will not added no ? otherwise you need to need to have QStringLiteral("inserted")
213	readOnly true... it's wierd.... we need to know why it's readonly
256	yep todo
autotests/usertest.cpp
45	? what is the error?
137	We need to do it because for the moment yep we use this code: " const QJsonObject fields = object.value(QLatin1String("fields")).toObject(); setName(fields.value(QLatin1String("name")).toString()); setUserId(object.value(QLatin1String("id")).toString()); setStatus(fields.value(QLatin1String("status")).toString());" so we know that we use setName/setStatus etc. but perhaps in the future we will change and assign directly as value > signal will not emit and it will be an error > test signal too.
159	!= please :)
src/roommodel.cpp
233	qCDebug(...)

This revision now requires changes to proceed.Jan 5 2018, 6:08 AM

Modify the code

clarity on updateRoom(QJsonObject)

can you please tell me exactly what updateRoom should do in roomModel.cpp?
It should update the existing values or It should update the existing values and add new values passed through arguments.

diff b/w "updated" case and "changed" in roomModel.cpp??

autotests/roommodeltest.cpp
213	Sry, I actually raised this issue in L138 only !! in the previous update, same problem here also
autotests/usertest.cpp
45	Sry, NO ERROR
159	we don't have != for User class, thats why I used ! ( == )

velurimithun added inline comments.Jan 5 2018, 8:24 AM

autotests/rocketchataccountsettingstest.h
50 ↗	(On Diff #24748)	I'll remove this in next update

mlaurent added inline comments.Jan 5 2018, 8:53 AM

autotests/usertest.cpp
159	Add the missing operator in class.

Fix parseUpdateRoom method in room.cpp

oom(QJsonObject) used the above method for updating name, satus, announcements but that method in room.cpp doesn't update name of the room from QJsonObject.

Now it if fixed, name also will be updated.

velurimithun marked 3 inline comments as done.Jan 5 2018, 4:30 PM

velurimithun added inline comments.

autotests/roommodeltest.cpp
65	changed the code for findRoom in roomModel.cpp NO ERROR it returns new roomWrapper with no room initialized in it but, when u try to access the name of the room then we'll get null pointer access error! that is in commented line.
130	It is fixed now:) problem was in praseUpdate method in room.cpp class, it was not updating name. pl. have a look at changes in room.cpp file forgot to remove comment "here it fails!", it will be removed in next update.
188	shouldUpdateSubcriptionActionChanged is not tested, since changed case in updateSubscription method in roomModel doesn't do anything new other than updating pl. have a look at updateSubcription method in roomModel.cpp

Add test for data in roomModel

mlaurent requested changes to this revision.Jan 7 2018, 10:40 AM

mlaurent added inline comments.

autotests/roommodeltest.cpp
70	So you need to test that pointer is null here. Otherwise it's not necessary to use findRoom if you don't test value. But I prefere that we check this value
257	Good for testing default value but please add a test when it's not default value too thanks.
autotests/usertest.cpp
50	QCOMPARE(current value, expected) same for other QCOMPARE
src/roommodel.cpp
77	If we don't find roomId we mustn't create a new RoomWrapper. We need to check nullptr in return value otherwise we will create a not existing room.
233	qCDebug(debug categori") and uncomment it please.
src/user.cpp
82	heu... return !User::operator(User) it doesn't work ? We don't need to add duplicate code.

This revision now requires changes to proceed.Jan 7 2018, 10:40 AM

write non-default test cases for data method in roomModel

rewrite QCOMPARE() properly in userTest.cpp
log the print statments in roomModel to RUQOLA_LIB through qCDebug
change the findRoom method to return nullptr if it doesn't find room!

velurimithun added inline comments.Jan 7 2018, 4:22 PM

autotests/usertest.cpp
50	Done it in roomModelTest but forgot in userTest now, it is corrected everywhere!:)

velurimithun retitled this revision from << Add autotest for roommodel >> to Add autotest for roommodel and user classes.Jan 7 2018, 4:23 PM

mlaurent requested changes to this revision.Jan 9 2018, 6:57 AM

mlaurent added inline comments.

autotests/roommodeltest.cpp
345	compare with selected value no ?
365	QCOMPARE(..., favorite)
autotests/usertest.cpp
50	QCOMPARE(value, expected)
74	QCOMPARE(value, expected) please verify each QCOMPARe
src/roommodel.cpp
233	RUQOLA_LOG without () I know that it compiles but we use by default without () same for others code

This revision now requires changes to proceed.Jan 9 2018, 6:57 AM

Fix minor errors

Fixed

mlaurent added inline comments.Jan 10 2018, 5:52 AM

src/roommodel.cpp
233	RUQOLA_LOG without () ...

Use () for qCDebug(RUQOLA_LOG) in roomModel.cpp

velurimithun marked an inline comment as done.Jan 11 2018, 6:23 PM

mlaurent added inline comments.Jan 11 2018, 9:56 PM

src/roommodel.cpp
233	nope "RUQOLA_LOG without () I know that it compiles but we use by default without () same for others code" > qDebug(RUQOLA_LOG) << ...

Remove () after RUQOLA_LOG in qCDebug()

velurimithun marked an inline comment as done.Jan 12 2018, 3:08 AM

mlaurent requested changes to this revision.Jan 12 2018, 5:59 AM

mlaurent added inline comments.

tests/CMakeLists.txt
63 ↗	(On Diff #25195)	Remove all this code.... Please create several branch where you put specific code as autotests and and other one for qmlFileTestResources git checkout -b add_autotest_room_model for this one and git checkout -b add_qmltest for other one. Please rebase from master I changed a lot of thing.

This revision now requires changes to proceed.Jan 12 2018, 5:59 AM

Undo the changes for qmlTestApp

Seems ok now.
Thanks

This revision is now accepted and ready to land.Jan 12 2018, 6:39 PM

Closed by commit R865:1e58cc64f1e0: Add autotest for roommodel and user classes (authored by velurimithun). · Explain WhyJan 14 2018, 11:39 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/roommodeltest.h (15 lines)
M			autotests/roommodeltest.cpp (350 lines)
M			autotests/usertest.h (6 lines)
M			autotests/usertest.cpp (131 lines)
M			src/room.cpp (3 lines)
M			src/roommodel.cpp (17 lines)
M			src/user.h (1 line)
M			src/user.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24682	5ca3bac		Jan 3 2018, 6:52 PM	★	★
Diff 2	24715	5ca3bac	- Change updateRoom method in roomModel and add tests for roomModel	Jan 4 2018, 2:09 PM	★	★
Diff 3	24730	5ca3bac	- Add test cases for user	Jan 4 2018, 5:57 PM	★	★
Diff 4	24748	5ca3bac	- Add more tests to user and roomModel	Jan 5 2018, 5:07 AM	★	★
Diff 5	24752	5ca3bac	- Modify the code	Jan 5 2018, 8:21 AM	★	★
Diff 6	24780	5ca3bac	- Fix parseUpdateRoom method in room.cpp	Jan 5 2018, 4:09 PM	★	★
Diff 7	24810	5ca3bac	- Add test for data in roomModel	Jan 6 2018, 5:06 AM	★	★
Diff 8	24887	5ca3bac	- write non-default test cases for data method in roomModel	Jan 7 2018, 4:21 PM	★	★
Diff 9	25020	5ca3bac	- Fix minor errors	Jan 9 2018, 1:51 PM	★	★
Diff 10	25179	1f29951	Use () for qCDebug(RUQOLA_LOG) in roomModel.cpp	Jan 11 2018, 6:22 PM	★	★
Diff 11	25195	5ca3bac	- Remove () after RUQOLA_LOG in qCDebug()	Jan 12 2018, 3:07 AM	★	★
Diff 12	25214	5ca3bac	- Undo the changes for qmlTestApp	Jan 12 2018, 10:26 AM	★	★
Diff 13	25306	03034ec	R865:1e58cc64f1e0ac14107bfcc3c75072a7abd0ec7e	Jan 14 2018, 11:38 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f633bea59c86	9f9274bb86b4	954b0d834e07	Veluri Mithun	Undo the changes for qmlTestApp (Show More…)	Jan 12 2018, 10:21 AM
954b0d834e07	59fc855c0488	b0ffecfe93b6	Veluri Mithun	Remove () after RUQOLA_LOG in qCDebug() (Show More…)	Jan 12 2018, 3:05 AM
b0ffecfe93b6	8afee9c4a243	1f29951d5f6b	Veluri Mithun	Use () for qCDebug(RUQOLA_LOG) in roomModel.cpp	Jan 11 2018, 6:19 PM
1f29951d5f6b	33c5d1c0aab8	259eb095c3a9	Veluri Mithun	Create test app to test qml files (Show More…)	Jan 11 2018, 5:52 PM
259eb095c3a9	c9a59e23da34	0e8bb8cc9067	Veluri Mithun	Fix minor errors	Jan 9 2018, 1:50 PM
0e8bb8cc9067	7aee2a56be2d	de848cd10679	Veluri Mithun	write non-default test cases for data method in roomModel	Jan 7 2018, 4:17 PM
de848cd10679	d0de6782e23a	2939bfd9e1b5	Veluri Mithun	Add test for data in roomModel	Jan 6 2018, 5:06 AM
2939bfd9e1b5	03fdbe8f206b	90b959b1d57d	Veluri Mithun	Fix parseUpdateRoom method in room.cpp (Show More…)	Jan 5 2018, 4:03 PM
90b959b1d57d	6ae7c3d1d11f	32724f1c8615	Veluri Mithun	Modify the code	Jan 5 2018, 8:20 AM
32724f1c8615	1338978b0d9d	fde05867a0fd	Veluri Mithun	Add more tests to user and roomModel	Jan 5 2018, 5:06 AM
fde05867a0fd	283e28d75780	c4ac0efdb48a	Veluri Mithun	Add test cases for user	Jan 4 2018, 5:57 PM
c4ac0efdb48a	18a49400f146	1211b3ed6078	Veluri Mithun	Change updateRoom method in roomModel and add tests for roomModel	Jan 4 2018, 2:04 PM
1211b3ed6078	8d2d1778c94a	eb51dd5a929b	Veluri Mithun	<< Add autotest for roommodel >> (Show More…)	Jan 3 2018, 6:42 PM
eb51dd5a929b	f8cab81b688a	8cfc213e3455 5ca3bac9af44	Veluri Mithun	Merge branch 'master' of https://anongit.kde.org/ruqola	Jan 3 2018, 3:14 PM
8cfc213e3455	584586e42314	da5e831404e4 5adcc144f498	Veluri Mithun	Merge branch 'master' of https://anongit.kde.org/ruqola	Dec 21 2017, 4:09 PM
da5e831404e4	8f4634d4f07a	7e94ac64bdbc	Veluri Mithun	Modify the shouldNotEmit methods	Dec 19 2017, 7:19 AM
7e94ac64bdbc	af86a303c0b4	a320ba4fba09	Veluri Mithun	Signal should not be emitted when same url,name is passed	Dec 19 2017, 2:37 AM
a320ba4fba09	faa04a6cca33	58116e41feeb	Veluri Mithun	Add empty string case in setServerUrl, SetUsername	Dec 18 2017, 4:43 PM
58116e41feeb	3a5dd30cd64a	8bf12ee3297e	Veluri Mithun	Split test cases for username and serverUrl	Dec 18 2017, 2:08 PM
8bf12ee3297e	7299b23fec97	46011b6f406e	Veluri Mithun	Create new test for logout	Dec 18 2017, 8:46 AM
46011b6f406e	e0a764732a54	77596351a57b	Veluri Mithun	Add test cases for rocketchataccountsettings (Show More…)	Dec 18 2017, 2:17 AM
77596351a57b	dda57fdaf7d0	a3ff1195090b	Veluri Mithun	Add test cases for rocketschataccountsettings	Dec 17 2017, 6:20 PM
a3ff1195090b	f2536292491b	abfafc61b57a	Veluri Mithun	Add defaultValues test for rocketchataccountsettings	Dec 17 2017, 8:01 AM

Add autotest for roommodel and user classes
ClosedPublic
Actions

Details

Diff Detail

> QCompare(spy.count(), 1)

> signal will not emit and it will be an error

> test signal too.

> qDebug(RUQOLA_LOG) << ...

Revision Contents
Changeset List

Diff 25306

autotests/roommodeltest.h

autotests/roommodeltest.cpp

autotests/usertest.h

autotests/usertest.cpp

src/room.cpp

src/roommodel.cpp

src/user.h

src/user.cpp

Add autotest for roommodel and user classesClosedPublicActions

Details

Diff Detail

> QCompare(spy.count(), 1)

> signal will not emit and it will be an error

> test signal too.

> qDebug(RUQOLA_LOG) << ...

Revision ContentsChangeset List

Diff 25306

autotests/roommodeltest.h

autotests/roommodeltest.cpp

autotests/usertest.h

autotests/usertest.cpp

src/room.cpp

src/roommodel.cpp

src/user.h

src/user.cpp

Add autotest for roommodel and user classes
ClosedPublic
Actions

Revision Contents
Changeset List