Differential D9634

Fix build with Qt 5.6
ClosedPublic
Actions

Authored by wbauer on Jan 3 2018, 10:56 AM.

Details

Reviewers
mardelle
Group Reviewers
Kdenlive
Summary

Q(Gui)Application::setDesktopFileName() was introduced in Qt 5.7, but kdenlive specifies 5.6.0 as minimum version in CMakeLists.txt.

Test Plan

Builds fine now with Qt 5.6.2 (failed before) and 5.10.0.

Diff Detail

Repository
R158 Kdenlive
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer requested review of this revision.Jan 3 2018, 10:56 AM
wbauer created this revision.
wbauer added a subscriber: mardelle.Jan 8 2018, 8:12 AM
wbauer added a subscriber: vpinon.Jan 8 2018, 11:06 PM
mardelle accepted this revision.Jan 22 2018, 12:26 PM
This revision is now accepted and ready to land.Jan 22 2018, 12:26 PM
wbauer closed this revision.Jan 22 2018, 3:06 PM

Committed with https://phabricator.kde.org/R158:94c420c85b55d5fabeebc38984f0afcbe3cc9e93, forgot to mention this differential in the commit message...

wbauer added a comment.Jan 22 2018, 3:14 PM

PS: Should I merge Applications/17.12 into master? Or will somebody else do it at some point?
There have been other changes in the 17.12 branch, and the last merge was in November AFAICS....

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (2 lines)

Diff 24656

View Options

src/main.cpp

Loading...