Add a private libPlasmaWeatherSolar for the ion data engines
AbandonedPublic

Authored by kossebau on Jan 3 2018, 10:27 AM.

Details

Reviewers
jriddell
Group Reviewers
Plasma
Summary

The weather ion dataengines used to take care for weather observation
reports whether it was day or night at the given location ATM, and to choose
icons with the sun or the moon respectively.
For that they made use of the time dataengine which provides calculated data
for solar-system related things. Though that calculation services was
queried with a sync call, which is no longer existing in Plasma5 age.

While it might have been possible to switch to async querying of the time
dataengine, the needed additional bookkeeping of the new states would add
quite some complexity. Where the straight call into the respective
calculation code is both more simple and also avoids additional default
calculation done by the time dataengine.

Because the "solarsystem" code in the time dataengine is not separatly
available, this patch copies the code files over and adapts them as
minimally as needed.
As the solarsystem code is also GPL, mixing it as private API into the
LGPL weather_ion library seems not recommended.
So a separate private shared library is created installed and used/linked
from the weather ion data engines.

Test Plan

Weather observation reports for BBCUKMET, NOAA & ENVCAN show icons with the
moon instead of the sun for locations where it currently is night.

Diff Detail

Repository
R120 Plasma Workspace
Branch
addPrivateSolarSystemLibforIons
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Jan 3 2018, 10:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2018, 10:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 3 2018, 10:27 AM

Better ideas very welcome, this is just a desperate first shot at the challenge.

(Yes, right in time before feature freeze, boh me. One could also claim though it is rather a late Plasma5 porting regression fix ;) )

kossebau abandoned this revision.Jan 9 2018, 12:12 AM

Discarding this one and instead went the route of async querying from the time dataengine...