Fix icon name "weather-none" -> "weather-none-available"
ClosedPublic
Actions

Authored by kossebau on Jan 3 2018, 1:00 AM.

Details

Reviewers

Group Reviewers

Frameworks
Breeze

Commits

R266:87cef4dd7856: Fix icon name "weather-none" -> "weather-none-available"

Summary

"weather-none-available" has been the traditional name in Oxygen and
is referenced as such in existing KDE and non-KDE code, also used as
name in other icon themes (e.g. Numix).

One could argue that the icon fallback mechanism should still result
in "weather-none" being used with Breeze. Issues with that though are:

is inconsistent naming with other icon themes (incl. Oxygen)
fails with distributions patching the Breeze theme to inherit Oxygen, as then the Oxygen icon will be used.

BUG: 379875

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jan 3 2018, 1:00 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 3 2018, 1:00 AM

kossebau requested review of this revision.Jan 3 2018, 1:00 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 5 2018, 9:54 PM

Closed by commit R266:87cef4dd7856: Fix icon name "weather-none" -> "weather-none-available" (authored by kossebau). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
V			icons-dark/applets/48/{weather-none-available.svg ← weather-none.svg}
V			icons-dark/applets/48/{weather-none.svg → weather-none-available.svg}
V			icons/applets/48/{weather-none-available.svg ← weather-none.svg}
V			icons/applets/48/{weather-none.svg → weather-none-available.svg}