Improve UI for Instant Preview Threshold slider
Needs RevisionPublic
Actions

Authored by scottpetrovic on Dec 31 2017, 3:57 PM.

Details

Reviewers

Group Reviewers

Summary

Right now the Instant Preview threshold slider is in the brush editor at the bottom. You have to click the "Instant Preview" checkbox at the bottom, then right click to see the slider option. This could be improved and more easily accessible.

I moved the slider to be at the bottom of the brush editor without any extra clicks.
I also added "px" suffixes to the instant preview tooltip dealing with the threshold.

here is a screenshot with what it looks like after the patch is applied...

Test Plan

Saved a few different brush presets with different instant preview thresholds.
Then started switching between brush presets and watched the lod threshold change
moved the brush size slider up and down to see instant preview get turned on and off

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

scottpetrovic requested review of this revision.Dec 31 2017, 3:57 PM

scottpetrovic created this revision.

Hi, Scott!

I cannot say I really like how the final result looks like. Especially how the word "Instant Preview" in repeated twice in one line. Is it possible to combine the checkbox and the slider (probably in one widget) so that we could write one word "Threshold" only?

Though I don't feel myself competent enough in UIX, so I will accept the painters' opinion about the visual part.

From the technical point of view there are three small issues that need fixing:

When Instant Preview is unchecked/not available, the slider must be disabled. That is a regression compared to the current state.
Title case vs sentence case in the slider. I'm not sure which is correct (see the inlined comment).
Please rebase the patch and add a signals blocker (see inlined comment)

The rest looks fine.

libs/ui/forms/wdgpaintopsettings.ui
768	I'm not sure... what is is the correct way of writing such thing in English: "Instant preview threshold" or "Instant Preview threshold" or "Instant Preview Threshold"? I couldn't find the KDE policy for that... (though it surely exists). Personally, I like the first variant more...
libs/ui/widgets/kis_paintop_presets_popup.cpp
450	You will have a conflict with master because of that. Please add the following line before settings the value: KisSignalsBlocker b(m_d->uiWdgPaintOpPresetSettings.ipThresholdSlider); It will fix the cycling dependency that is fixed in master.

This revision now requires changes to proceed.Jan 4 2018, 6:05 PM

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/forms/wdgpaintopsettings.ui (220 lines)
M			libs/ui/widgets/kis_lod_availability_widget.h (3 lines)
M			libs/ui/widgets/kis_lod_availability_widget.cpp (50 lines)
M			libs/ui/widgets/kis_paintop_presets_popup.cpp (24 lines)