Improve error message when parttest fails due to missing pdflatex
ClosedPublic

Authored by rkflx on Dec 31 2017, 2:52 PM.

Details

Summary

PartTest::testForwardPDF tests whether the synctex integration works
and needs to create a PDF from latex sources via pdflatex.
If this is not installed the test fails, but the error message
'started' returned FALSE requires diving into the source code to debug
the problem.

By providing a more meaningful error message we make it easier for
developers and distributions to run all autotests sucessfully (short of
build-requiring a latex installation). Note that Albert does not want to
simply skip the tests in that case, so no optional build-time dependency
either.

Ref T7532

Test Plan

Run parttest testForwardPDF w/ and w/o pdflatex executable
available.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Dec 31 2017, 2:52 PM
Restricted Application added a project: Okular. · View Herald TranscriptDec 31 2017, 2:52 PM
Restricted Application added a subscriber: Okular. · View Herald Transcript
rkflx requested review of this revision.Dec 31 2017, 2:52 PM
rkflx added a reviewer: Okular.Jan 1 2018, 7:35 AM
aacid accepted this revision.Jan 1 2018, 11:51 PM
This revision is now accepted and ready to land.Jan 1 2018, 11:51 PM
This revision was automatically updated to reflect the committed changes.