Fix for bug 340072: make it possible to enter colors as percentages
ClosedPublic
Actions

Authored by dyurshevich on Dec 28 2017, 11:22 AM.

Details

Reviewers

Commits

R37:14c298120cb3: Make it possible to enter color values as percentage
R37:f05a29add48d: Make it possible to enter color values as percentage

Summary

Now it only works for int-family depths. Not sure if its necessary to be able to use percents with float. The code itself can be improved of course. I just want to know if i'm going in a right direction.

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dyurshevich created this revision.Dec 28 2017, 11:22 AM

Restricted Application added a subscriber: woltherav. · View Herald TranscriptDec 28 2017, 11:22 AM

dyurshevich requested review of this revision.Dec 28 2017, 11:22 AM

rempt retitled this revision from Fix for bug 340072 to Fix for bug 340072: make it possible to enter colors as percentages.Dec 28 2017, 12:48 PM

Yes, this looks good to me. I'd rephrase the checkbox as "Use Percentage" or something like that, apart from that, I'm fine with the patch. I would like to get it in before string freeze, December 31st!

You mean the only thing that have to be fixed is the checkbox name?

yes, fix it, update the diff and we'll push it :)

Ok, thanks

Checkbox name updated

This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2017, 11:51 AM

Closed by commit R37:f05a29add48d: Make it possible to enter color values as percentage (authored by rempt). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/widgets/kis_color_input.h (18 lines)
M			libs/ui/widgets/kis_color_input.cpp (116 lines)
M			plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.h (2 lines)
M			plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.cc (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24412			Dec 28 2017, 11:11 AM	★	★
Diff 2	24450			Dec 29 2017, 10:52 AM	★	★
Diff 3	24451	15de323	R37:f05a29add48d8a051ecff84c55ea6a6813381ace	Dec 29 2017, 11:49 AM	★	★