Differential D9520

Get rid of MaxWidthImageButton
ClosedPublic
Actions

Authored by nicolasfella on Dec 27 2017, 7:27 PM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:de7d9442300f: Get rid of MaxWidthImageButton
Summary

There is no need to implement a custom view for that. It is only used in MPRIS Activity, which looks almost the same now, except that the play button aligns with the buttons beneath, which is better IMHO.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Dec 27 2017, 7:27 PM
nicolasfella created this revision.
mtijink accepted this revision.Jan 28 2018, 9:08 PM
This revision is now accepted and ready to land.Jan 28 2018, 9:08 PM
Closed by commit R225:de7d9442300f: Get rid of MaxWidthImageButton (authored by nicolasfella). · Explain WhyFeb 1 2018, 10:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26306

View Options

res/layout/mpris_control.xml

Loading...
View Options

res/values/attrs.xml

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/MaxWidthImageButton.java

Loading...