Replace the flaky features run script with a proper executable
ClosedPublic
Actions

Authored by ervin on Feb 15 2016, 10:21 PM.

Details

Reviewers

bensi
dfaure
franckarrecot

Commits

R4:b8b65acd43eb: Replace the flaky features run script with a proper executable

Summary

This way we can properly wait for the cuke steps server to show up
before launching cucumber which removes the race (and thus random
failure) we were seeing on the acceptance tests.

I had to adjust cucumber-cpp a bit so that it doesn't quit after the
first connection attempt.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 2314.Feb 15 2016, 10:21 PM

ervin retitled this revision from to Replace the flaky features run script with a proper executable.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot, dfaure.

dfaure accepted this revision.Feb 15 2016, 10:33 PM

dfaure edited edge metadata.

dfaure added inline comments.

tests/features/features-run.cpp
75	You could add a waitForStarted(), to increase the chances that the first waitForConnected() succeds? Just an idea. Might also help with error handling in case the process fails to start (e.g. segfault, binary not found, missing lib etc.).
78	I'm surprised that you need this Q_UNUSED (and the one for app above), is that for a compiler or an IDE? They should both accept the RAII pattern ;)

This revision is now accepted and ready to land.Feb 15 2016, 10:33 PM

Address dfaure's comments

ervin marked 2 inline comments as done.Feb 16 2016, 6:07 AM

bensi accepted this revision.Feb 16 2016, 8:22 AM

bensi edited edge metadata.

Closed by commit R4:b8b65acd43eb: Replace the flaky features run script with a proper executable (authored by ervin). · Explain WhyFeb 16 2016, 8:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		3rdparty/cucumber-cpp/src/main.cpp (3 lines)
M		tests/features/CMakeLists.txt (3 lines)
D	M	tests/features/CucumberTests.cmake (49 lines)
D	M	tests/features/cucumber-akonadi-run.sh.in (26 lines)
D	M	tests/features/cucumber-run.sh.in (19 lines)
A	M	tests/features/features-run.cpp (90 lines)
M		tests/features/renku/CMakeLists.txt (10 lines)
M		tests/features/zanshin/CMakeLists.txt (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2314	4762022		Feb 15 2016, 10:21 PM	★	★
Diff 2	2316	4762022	Address dfaure's comments	Feb 16 2016, 6:06 AM	★	★
Diff 3	2317	4762022	rZANSHINb8b65acd43ebf0f98dcf408e61bf72951effe55c	Feb 16 2016, 6:06 AM	★	★