Properly check for Breeze GTK 3 theme existence in kconf_update
ClosedPublic

Authored by fvogt on Dec 21 2017, 4:38 PM.

Details

Summary

The gtk-3.0 directory is not mandatory and is gone.

Test Plan

Ran kconf_update_bin/gtkbreeze5.5, settings.ini with Breeze as theme gets created again.

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Dec 21 2017, 4:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 21 2017, 4:38 PM
fvogt requested review of this revision.Dec 21 2017, 4:38 PM
apol requested changes to this revision.Dec 21 2017, 6:51 PM
apol added a subscriber: apol.
apol added inline comments.
kconf_update/main.cpp
37

Seems like it would return a bool.

I would change it to gtk3ThemeInstalledPath(). I know it wasn't your idea and there's already a isGtkThemeInstalled for gtk2, but it looks hard to figure out still. Feel free to change the other one if you like.

44

+ QLatin1Char('/') +

47

return {};

160

Does this need fixing too?

This revision now requires changes to proceed.Dec 21 2017, 6:51 PM
fvogt marked 3 inline comments as done.Dec 21 2017, 7:23 PM
fvogt added inline comments.
kconf_update/main.cpp
160

No, that's the location of the config file, which is always ~/.config/gtk-3.0/settings.ini. Maybe it can be overwritten, but that would cause other problems.

fvogt updated this revision to Diff 24268.Dec 21 2017, 7:23 PM

Adress review comments.

apol accepted this revision.Dec 22 2017, 1:30 AM

LGTM

This revision is now accepted and ready to land.Dec 22 2017, 1:30 AM
jackg accepted this revision.Dec 22 2017, 6:56 AM
This revision was automatically updated to reflect the committed changes.