Inform the user if the module can not be registered with org.kde.kded5 and exit with error
ClosedPublic

Authored by habacker on Dec 21 2017, 1:21 PM.

Details

Summary

It makes no sense to run this test app without registering with kded5
as this is a required requirement.

Test Plan

compiled and tested without running kded5

Diff Detail

Repository
R239 KDELibs4Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker created this revision.Dec 21 2017, 1:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 21 2017, 1:21 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
habacker requested review of this revision.Dec 21 2017, 1:21 PM
habacker updated this revision to Diff 24223.Dec 21 2017, 1:30 PM
  • really shut down app in case of errors
dfaure requested changes to this revision.Dec 21 2017, 1:37 PM

kded5 is supposed to be autostarted on demand by the DBus activation mechanism, but OK, if the setup is broken, I guess that might fail.

tests/networkingservice.cpp
68

KF5 coding style: { ... } even around 1-line bodies.

69

kError() is deprecated, use qCritical()

235

this line serves no purpose, since exec() wasn't even called.

This revision now requires changes to proceed.Dec 21 2017, 1:37 PM
habacker updated this revision to Diff 24224.Dec 21 2017, 1:48 PM
  • follow code style
  • do not call quit()
dfaure accepted this revision.Dec 21 2017, 2:07 PM
This revision is now accepted and ready to land.Dec 21 2017, 2:07 PM
This revision was automatically updated to reflect the committed changes.