Differential D9422

[Connection Item] Use QtQuick's built-in HSV color features for cycling download color
ClosedPublic
Actions

Authored by broulik on Dec 20 2017, 9:13 AM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:02684b9041d7: [Connection Item] Use QtQuick's built-in HSV color features for cycling…
Test Plan

Qt.hsva was added in Qt 5.5 and the hsvHue stuff was merged in July 2016, so should be fine to use now.

Color looks the same as before. Value needs to be [0,1] hence the +0.5 and modulo. I tried just +='ing hsvHue but that didn't work.

Btw, isn't that just inverting the color? ie. we could just 1-r, 1-g, 1-b the color?

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 20 2017, 9:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2017, 9:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 20 2017, 9:13 AM
jgrulich accepted this revision.Dec 20 2017, 9:16 AM
This revision is now accepted and ready to land.Dec 20 2017, 9:16 AM
Closed by commit R116:02684b9041d7: [Connection Item] Use QtQuick's built-in HSV color features for cycling… (authored by broulik). · Explain WhyDec 21 2017, 11:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24213

View Options

applet/contents/ui/ConnectionItem.qml

Loading...