Sorry improper usage of Arcanist here. This was split in two patches in my repo but with Arc diff this apparently got squashed into one.
I'll try to fix.

This is the diff that only contains fixes for Qt deprecated features.

Other than that, looks good! +1

kleopatra/commands/importcertificatescommand.cpp
203 ↗	(On Diff #2256)	The original one filtered using isEmpty()
kleopatra/utils/auditlog.cpp
40 ↗	(On Diff #2256)	You didn't include any QUrlQuery uses...?

Update to filter for empty sources again in importmodel tooltip.

aheinecke marked an inline comment as done.Feb 9 2016, 7:35 PM

aheinecke added inline comments.

kleopatra/commands/importcertificatescommand.cpp
203	Thanks, you are right I misunderstood the code and thought this would only call Qt::escape if the string is not empty. So I checked that toHtmlEscaped can handle empty values. Hurray for obfuscated code. Btw. this was the only place where transform_if is used in Kleopatra. Happy it's gone now ;-)
kleopatra/utils/auditlog.cpp
40 ↗	(On Diff #2256)	No but in line 74 there is a use of it. That this worked previously is probably because of an implicit include that's changed by the compatibility setting. Without this include it does not compile with an invalid use of incomplete type error.

seems ok for me

aheinecke marked 3 inline comments as done.Feb 10 2016, 3:19 PM

Submitted with: http://commits.kde.org/kdepim/0519bac2c39992c85b7c07c5f1300052bad5cbeb

Revision Contents
Changeset List

			Path	Packages
M			kleopatra/commands/importcertificatescommand.cpp (9 lines)
M			kleopatra/dialogs/certificatedetailsdialog.cpp (2 lines)
M			kleopatra/kleopatraapplication.cpp (2 lines)
M			kleopatra/models/keylistmodel.cpp (3 lines)
M			kleopatra/models/subkeylistmodel.cpp (10 lines)
M			kleopatra/models/useridlistmodel.cpp (10 lines)
M			kleopatra/utils/auditlog.cpp (1 line)
M			kleopatra/utils/headerview.cpp (4 lines)
M			kleopatra/utils/log.h (3 lines)
M			kleopatra/utils/log.cpp (10 lines)