substantially refine the path x-platform path displaying
ClosedPublic

Authored by sitter on Dec 11 2017, 12:56 PM.

Details

Summary
  • File::name is now File::decodedName
  • new File::displayName which properly applies separators to the name (on Windows src/ should be src\)

The motivation behind this change is to force us having to make a decision
if we want the low-overhead name or the high-overhead UI name.

  • File::fullPath is now File::displayPath for the same reason as above
  • new File::url as a convenience wrapper used by the display* functions to construct a full URL out of their tree so we can determine whether the path is local or remote (scheme file:// vs. http:// etc.)
  • RadialMap::Widget::mouseMoveEvent had its tooltip adjusted to not resolve it against the held tree but rather the entities tree. This was inconsistent with hover signals emitted and caused remote paths to get improperly displayed like local paths in the tooltip while being correctly displayed as URLs in the rest of the UI
Test Plan
  • paths work beautifully on win32
  • filelighting over sftp:// also has correct paths now

Diff Detail

Repository
R352 Filelight
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Dec 11 2017, 12:56 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptDec 11 2017, 12:56 PM
sitter requested review of this revision.Dec 11 2017, 12:56 PM
This revision was automatically updated to reflect the committed changes.